bug#20908: 25.0.50; gnutls-negotiate error "Invalid format operation %u"

bug#20908: 25.0.50; gnutls-negotiate error "Invalid format operation %u"

[lo2net]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

Hi all,
I've got a problem: when using (gnutls-negotiate :verify-error t) to initialize a SSL/TLS
connection , server has an expired certificate cause gnutls-boot signal
an error "Invalid format operation %u", apparently it's not related to
gnutls-error. So digging into the source
code, here is the error signal:

src/gnutls.c:1511

      if (verify_error_all
          || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
        {
	  emacs_gnutls_deinit (proc);
	  error ("Certificate validation failed %s, verification code %u",
		 c_hostname, peer_verification);
        }

After checking elisp manual and source code, function Fformat(error call
it to format string) does not
support '%u', here should using '%d' instead.

I made a simple patch for this:

[-- Attachment #2: 0001-gnutls-boot-fix-error-Invalid-format-operation-u-whe.patch --]
[-- Type: text/plain, Size: 834 bytes --]

From d046b24f7cee1b30e45dd094c0299304cfd7c270 Mon Sep 17 00:00:00 2001
From: lo2net <fangtao0901@gmail.com>
Date: Thu, 25 Jun 2015 17:00:03 +0800
Subject: [PATCH] gnutls-boot: fix error "Invalid format operation %u" when
 certificate validation fail

---
 src/gnutls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gnutls.c b/src/gnutls.c
index cab2404..6a2c873 100644
--- a/src/gnutls.c
+++ b/src/gnutls.c
@@ -1512,7 +1512,7 @@ one trustfile (usually a CA bundle).  */)
           || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
         {
 	  emacs_gnutls_deinit (proc);
-	  error ("Certificate validation failed %s, verification code %u",
+	  error ("Certificate validation failed %s, verification code %d",
 		 c_hostname, peer_verification);
         }
       else
-- 
1.9.5.msysgit.1

bug#20908: 25.0.50; gnutls-negotiate error "Invalid format operation %u"

[Eli Zaretskii]

> From: lo2net <fangtao0901@gmail.com>
> Date: Sat, 27 Jun 2015 11:55:43 +0800
> 
> I've got a problem: when using (gnutls-negotiate :verify-error t) to initialize a SSL/TLS
> connection , server has an expired certificate cause gnutls-boot signal
> an error "Invalid format operation %u", apparently it's not related to
> gnutls-error. So digging into the source
> code, here is the error signal:
> 
> src/gnutls.c:1511
> 
>       if (verify_error_all
>           || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
>         {
> 	  emacs_gnutls_deinit (proc);
> 	  error ("Certificate validation failed %s, verification code %u",
> 		 c_hostname, peer_verification);
>         }
> 
> After checking elisp manual and source code, function Fformat(error call
> it to format string) does not
> support '%u', here should using '%d' instead.
> 
> I made a simple patch for this:

Thanks.  I used %x instead of %d in the change I just pushed, because
the peer_verification value is actually a bitwise OR of the various
bits, so displaying it in hex will make its interpretation easier.

With that, I'm marking this bug done.

bug#20908: 25.0.50; gnutls-negotiate error "Invalid format operation %u"

[tao fang]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Okay, thanks!

On Sat, Jun 27, 2015 at 4:05 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: lo2net <fangtao0901@gmail.com>
> > Date: Sat, 27 Jun 2015 11:55:43 +0800
> >
> > I've got a problem: when using (gnutls-negotiate :verify-error t) to
> initialize a SSL/TLS
> > connection , server has an expired certificate cause gnutls-boot signal
> > an error "Invalid format operation %u", apparently it's not related to
> > gnutls-error. So digging into the source
> > code, here is the error signal:
> >
> > src/gnutls.c:1511
> >
> >       if (verify_error_all
> >           || !NILP (Fmember (QCgnutls_bootprop_trustfiles,
> verify_error)))
> >         {
> >         emacs_gnutls_deinit (proc);
> >         error ("Certificate validation failed %s, verification code %u",
> >                c_hostname, peer_verification);
> >         }
> >
> > After checking elisp manual and source code, function Fformat(error call
> > it to format string) does not
> > support '%u', here should using '%d' instead.
> >
> > I made a simple patch for this:
>
> Thanks.  I used %x instead of %d in the change I just pushed, because
> the peer_verification value is actually a bitwise OR of the various
> bits, so displaying it in hex will make its interpretation easier.
>
> With that, I'm marking this bug done.
>

[-- Attachment #2: Type: text/html, Size: 1881 bytes --]