From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Rasmus Newsgroups: gmane.emacs.bugs Subject: bug#22399: org-mode fontification Date: Mon, 18 Jan 2016 19:48:17 +0100 Message-ID: <87bn8i7mha.fsf__30929.4437560768$1453154443$gmane$org@gmx.us> References: <87oacjng36.fsf@russet.org.uk> <87ziw36khb.fsf@gmx.us> <87a8o2zrtm.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1453154443 4040 80.91.229.3 (18 Jan 2016 22:00:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jan 2016 22:00:43 +0000 (UTC) Cc: 22399@debbugs.gnu.org To: phillip.lord@russet.org.uk Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 18 23:00:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aLHqi-0005vq-BD for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2016 23:00:32 +0100 Original-Received: from localhost ([::1]:33884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLHqh-0008I3-TP for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jan 2016 17:00:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLErR-0005sB-V8 for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 13:49:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLErO-0004Mu-LV for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2016 13:49:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLErO-0004Mq-Hp; Mon, 18 Jan 2016 13:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aLErO-00061U-84; Mon, 18 Jan 2016 13:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Rasmus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Mon, 18 Jan 2016 18:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22399 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 22399-submit@debbugs.gnu.org id=B22399.145314290723104 (code B ref 22399); Mon, 18 Jan 2016 18:49:02 +0000 Original-Received: (at 22399) by debbugs.gnu.org; 18 Jan 2016 18:48:27 +0000 Original-Received: from localhost ([127.0.0.1]:53194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLEqp-00060a-CU for submit@debbugs.gnu.org; Mon, 18 Jan 2016 13:48:27 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:64785) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aLEqn-00060N-96 for 22399@debbugs.gnu.org; Mon, 18 Jan 2016 13:48:26 -0500 Original-Received: from W530 ([62.80.108.9]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MVeCF-1aeErU0IsZ-00Z1Ex; Mon, 18 Jan 2016 19:48:19 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAMAAABg3Am1AAAANlBMVEX+/v7f3+CTk5O/v8C/ wMHPz8+fn6Cvr7C/wL92dXahoZ/AwL9MTEyAgH9gX19+f4AwLzN/gIBRedkoAAAACXBIWXMAAABI AAAASABGyWs+AAABfUlEQVRIDd3B0VbbQBBEwdstzYx3BYL8/88GYTCytD5xHpMq/gGyp5m/EInK xfMs4JLBs9TYZOdZ0diExZOisVHjGVGhamyi8UCJb2qVruTT1BkKZ4ovZsdiJJJwcBVN3CgZagJP fPHCTQYjaoIsNmEXNzInilryRZAFyGIvxUG89mmeJwFZgIM9JQc9uXEA6YUdc1S+iC/mgxs7FRwo X1ZxNRfQ2FNxr79N4qYL5IUdc68He1MIWvAjxR3ZYk9C4keKg7k1u4sHOiOqtTMiOg8EI9mCxyRO ojkYirf1tVmcRDaBOPAaHElsZidKcW9loAKIjGRdm8VeFQNeyjlX87unEDeKOV5Wzpa2CGaxF79a a3YWZ9E5m9bgEQcDsvsiBi5mLPz+xtnUxICytRQnYTMg58KZyilGmjgLu8RYBgfKluJKTRyVS3yR FjsnvskhdAlXEWGuFOXszp5pX4KdFIKoJYJ7+sTRpap6Zs+Ne9XCn+hDzDEvl6k24j/wGxJYCCwe kUkPAAAAAElFTkSuQmCC In-Reply-To: <87a8o2zrtm.fsf@russet.org.uk> (Phillip Lord's message of "Mon, 18 Jan 2016 18:05:25 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:ypzGs3PkLEBNRaxr5G5M78ob5dXdADgybwJILENeIr+DQwLXLbf 5JX8xnTnWDPZnSnodjehUjkigWVDLPMC7nAmF9EhBam3G++PMgj3igoTVIoT7A6jqYvjVuE jIh7caFUmaun5/QjuKOwLqEqeVepFL4b/W8MP18vnCEjvwvKxHnDHeKlomg19XkxcJkzFI+ gnXbZA/vbE3P9wv6YKL/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:1VkLnueXMkU=:0SjgiP1VYkSdtQholCzupk vmxuiHUfroJQt3UODMx0sUz22WSxUJQWQ0lIp8f22p5PYlnVpuByW8gJdC7n2X67DPCCh6qHq 5JVpCO6g+L8CYoED5RUVvnHSTIyZVj1wMlclxj9xBzrCRvgTxM3ee3/6nkAIiy95v/zyBTaZ3 RSEm3P8KW1RJzn27D1JXimuoAppJRjWqvgZkNBU4Pcm0d9lXsCiFgEfPRpQRJN++t1J+bjkUw DJduDtBeO/KWz9n4NnOSMnbijcgLYIsnd93z7tcxCADPMtlqEpTBoT4ztsXKsCrFtRrW9lv6N JZGmIt1e4boqFBKN5ySjkmRgZtNYRWPU+6C/C24SJs/sTlWaegyPgkeJtkwGN52ibN/TNCMo5 XVkACQkVd8mMTxaDGNNEei014UfvQw+jVw5TkcMxvoJXE7ROxuxOzdkTDWgO98oUTQHXHrvzS n5R3w1wAnel8NRcrm4hWAzmUqn9UeReZmTYhpF5fStUNXwG2vIES3ZY+kzbo2c8h5vipimT9y BmgU2xjdW70usr8VD8iSZL5cYiGBxjfEmlge3ElcSMCObya0Y/yiW4QwMIepIoeDUwsQRXvbn 3p+NkzG1+STKkPh6x4ZTlziSfBZUfiaueSRCuGApe39c2+N7snFUSO9jumOkLnFjQwAIv/+ZR NM9r9tLT5AgKwgouzDdYdy65Prf7/yV0TgGcT5fDjLTWlhcbAVih4LEgzxBvhLVR1rMaApphn BMzWmdKinB8yux1Mc9dBqyP9QcdoN9PgcunC+2/dyqnGSZidTd9DLckl5MKNqOPhnI+lfnHt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-Mailman-Approved-At: Mon, 18 Jan 2016 17:00:23 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111725 Archived-At: phillip.lord@russet.org.uk (Phillip Lord) writes: > Rasmus writes: > >> Hi Phillip, >> >> Thanks for your report. >> >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >>> On emacs-25 ox-html, line 1847, org-html-fontify-code does this... >>> >>> (setq code (with-temp-buffer >>> ;; Switch to language-specific mode. >>> (funcall lang-mode) >>> (insert code) >>> ;; Fontify buffer. >>> (org-font-lock-ensure) >>> >>> >>> But `org-font-lock-ensure' is defined like so.... >>> >>> (defalias 'org-font-lock-ensure >>> (if (fboundp 'org-font-lock-ensure) >>> #'font-lock-ensure >>> (lambda (_beg _end) (font-lock-fontify-buffer)))) >>> >>> >>> which takes two args, causing crashes when exporting to code to HTML. >> >> This is fixed in the most recent stable version of Org, i.e. 8.3.3=EF=BB= =BF=C2=B9 , >> which, I guess, will be part of if Emacs 25.2 or 26.1 (whichever comes >> first and allow new features). It=E2=80=99s also fixed in 8.2.10=EF=BB= =BF=C2=B2. I guess >> Emacs-25 should switch v8.2.10. [Honestly, when v8.3 couldn=E2=80=99t b= e merged I >> did not cross my mind to upgrade to v8.2.10]. In case v8.2.10 it too >> radical, a "local fix" must be applied to the version of Org in emacs.gi= t. > > > Well, the fix on emacs-25 appears to be trivial i.e. > > (org-font-lock-ensure (point-min) (point-max)) > > But I don't know what the protocol is for org-mode as it's upstream. > AFAICT, this is a regression from emacs-24.5, so it would be a shame if > the bug gets into 25.1. Sorry, I managed to confuse myself before. Emacs-25 has Org 8.2.10, but this bug only lives in the core version. Isn=E2=80=99t a better fix to change the signature of the alias to mirror t= hat of font-lock-ensure? I.e. (defalias 'org-font-lock-ensure (if (fboundp 'org-font-lock-ensure) #'font-lock-ensure (lambda (&optional _beg _end) (font-lock-fontify-buffer)))) Since (org-font-lock-ensure) is called from many places. Note, this change only lives it the Emacs version of Org. It was added in this commit: 6711a21f1125c0047c56eb266eb374c1ec90a967 Author: Stefan Monnier AuthorDate: Wed May 28 23:45:29 2014 -0400 * lisp/font-lock.el (font-lock-flush, font-lock-ensure): New function= s. * lisp/org/org-compat.el (org-font-lock-ensure): New function. * lisp/org/ox-odt.el (org-odt-do-format-code): * lisp/org/ox-html.el (org-html-fontify-code): * lisp/org/org.el (org-fontify-like-in-org-mode): * lisp/org/org-src.el (org-src-font-lock-fontify-block): * lisp/org/org-clock.el (org-clock-get-clocktable): Use it. * lisp/org/ox-org.el (org-org-publish-to-org): Use it. Avoid using f= ind-file from Elisp. * test/automated/ruby-mode-tests.el (ruby-assert-face): Use font-lock= -ensure. (ruby-interpolation-keeps-non-quote-syntax): Use syntax-propertize. I=E2=80=99ll check on font-lock-ensure business and whether we can use that= in Org-9. Thanks, Rasmus --=20 The right to be left alone is a human right