From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash Date: Wed, 27 Jan 2016 20:20:43 +0000 Message-ID: <87bn86ojtw.fsf@gmail.com> References: <87y4bcsogq.fsf@gmail.com> <83powo1j71.fsf@gnu.org> <87io2gns3b.fsf@gmail.com> <831t9414it.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1453943341 25231 80.91.229.3 (28 Jan 2016 01:09:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Jan 2016 01:09:01 +0000 (UTC) Cc: 22466@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 27 23:22:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOYTb-0005xg-GN for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2016 23:22:11 +0100 Original-Received: from localhost ([::1]:52881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOYTa-0007PM-Pd for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2016 17:22:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOYTX-0007PG-6i for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2016 17:22:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOYTS-0000LT-7N for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2016 17:22:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOYTS-0000LP-4K for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2016 17:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aOYTR-0006zN-UP for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2016 17:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jan 2016 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22466-submit@debbugs.gnu.org id=B22466.145393326326787 (code B ref 22466); Wed, 27 Jan 2016 22:22:01 +0000 Original-Received: (at 22466) by debbugs.gnu.org; 27 Jan 2016 22:21:03 +0000 Original-Received: from localhost ([127.0.0.1]:38998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOYSV-0006xx-JD for submit@debbugs.gnu.org; Wed, 27 Jan 2016 17:21:03 -0500 Original-Received: from mail-qg0-f42.google.com ([209.85.192.42]:34739) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOYSU-0006xA-C7 for 22466@debbugs.gnu.org; Wed, 27 Jan 2016 17:21:02 -0500 Original-Received: by mail-qg0-f42.google.com with SMTP id 6so19490728qgy.1 for <22466@debbugs.gnu.org>; Wed, 27 Jan 2016 14:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=LvYV0T284pZBtSEEcYiRg2HupklylUSlVGRG2H0B81Q=; b=kP4KnLU7Y5bzYTLF6YaYvw0m+F53vir6g42hsNzxncejnH6lLAwbER3DxiXE6B0Plk e0pi3uoQGnwGfP4ombunXzZsuK189/QPUYV/godixe3XAEw+i3MPGwOZa7/r1LQl/xCt 4x6Wrmrd+4fyQ1qtFem2kGCR+otN1ZAZyhS2s4oEYWLCr9NYCcAVjjkDk9XLpgMzsal/ AKB7/18aKXkuXW1JVDbt6wg514fGTsvxQ/AHE3tZ+wv+SnDVM+nquGj+YWiRVxAxSHAJ xR2H3J3SYY8dJTGSnZ56i8pc+UKRob0z8Tpz7Pq8AEpB9dAHpKAeCLTOCG6tmOkE5/8R uMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=LvYV0T284pZBtSEEcYiRg2HupklylUSlVGRG2H0B81Q=; b=YY2v1/FRTpLBdtkq0JWov5KafyDbUyUiPpC7e/APoeVUknffVLlXk2Ibi0JhupSF6j V7cXT7g/QmxwgSTm5PIGGjv7+eloITKhR9t0VnATvxBAkBlf4UOtYVgsRRSMqf/Jnk45 9zc56+snULkEANv0zt+58Pji4EOgfMjs9MSGbx9LeIZ6JJDxyJqkG057BG8WSjZfrTx7 Q3M4g+Hj2F+jV59HSE39d9cqU28JKWj1k1VD+DyedstD34+OkPgjnd74hBghaxmR68EA GgmTpp9RcVnR42lREBpVsQd4GF76mmVptslF68ChjRzNsaTMtQxtM6dsd6+nUn6EITwp 9I9w== X-Gm-Message-State: AG10YORzysf2s2eDZRztvcszrqbHUZC38zJSggMhdG447WxgXPnF+omEu3+XLXlBlcOLOg== X-Received: by 10.140.171.5 with SMTP id r5mr40730308qhr.51.1453933257031; Wed, 27 Jan 2016 14:20:57 -0800 (PST) Original-Received: from Gandalf-Linux.gmail.com ([201.37.162.188]) by smtp.gmail.com with ESMTPSA id v70sm2557583qkl.15.2016.01.27.14.20.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2016 14:20:56 -0800 (PST) In-Reply-To: <831t9414it.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jan 2016 22:15:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112040 Eli Zaretskii writes: > So disable-theme actually means go back to the default theme? If so, > when someone changes a theme, they don't really need to call > disable-theme, right? They could just call load-theme with the new > theme as an argument? I'm not sure why you reach this conclusion. `disable-theme' is meant to disable a single theme. If I have theme X enabled, then (disable-theme 'X) is supposed to restore the default Emacs appearance. If have two themes enabled (X and Y), then (disable-theme 'X) is supposed to give me just the appearance of theme Y. Right now, that's indeed what it does. But if I remove the form (as you asked) then it fails to do the above (it doesn't remove the background set by the disabled theme). > Then it would make sense to find a way of switching a theme without > changing the frame's background color, if that's possible (i.e. if the > new theme keeps the same background color). If there's a function > missing for that, I'd suggest to add one. How about just running that form only when necessary (i.e., only if the disabled theme actually sets the frame `background-color')?