From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#18131: 24.4.50; View-search-... skips all matches between (point) and edge of window Date: Tue, 23 Feb 2016 23:26:13 +1100 Message-ID: <87bn77oboa.fsf@gnus.org> References: <878undtl18.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456230445 4298 80.91.229.3 (23 Feb 2016 12:27:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 12:27:25 +0000 (UTC) Cc: 18131@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 23 13:27:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYC3a-00027D-2G for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 13:27:10 +0100 Original-Received: from localhost ([::1]:56605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYC3Z-0001XG-6r for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 07:27:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYC3V-0001X4-Df for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 07:27:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYC3S-0003NH-5W for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 07:27:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYC3S-0003NB-2M for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 07:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aYC3R-0008OB-Ry for bug-gnu-emacs@gnu.org; Tue, 23 Feb 2016 07:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18131-submit@debbugs.gnu.org id=B18131.145623040432205 (code B ref 18131); Tue, 23 Feb 2016 12:27:01 +0000 Original-Received: (at 18131) by debbugs.gnu.org; 23 Feb 2016 12:26:44 +0000 Original-Received: from localhost ([127.0.0.1]:39427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYC3A-0008NN-BA for submit@debbugs.gnu.org; Tue, 23 Feb 2016 07:26:44 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:56274) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYC38-0008NF-Q5 for 18131@debbugs.gnu.org; Tue, 23 Feb 2016 07:26:43 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYC2j-0006ib-4Z; Tue, 23 Feb 2016 13:26:17 +0100 In-Reply-To: <878undtl18.fsf@secretsauce.net> (Dima Kogan's message of "Mon, 28 Jul 2014 11:06:59 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aYC2j-0006ib-4Z MailScanner-NULL-Check: 1456835178.11094@BNThDfRnmtBNjleE4+LmGw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113584 Archived-At: Dima Kogan writes: > The emacs view-mode has navigation with 'n' and 'p' keys to navigate by > searching (like isearch, but with fewer keystrokes and very similar to > less and vi). > > I just discovered that unlike less and vi, this view-mode navigation > doesn't hit all the matches, but rather skips the ones between (point) > and the edge of the window. This ensures that any matches that are > visible by the user (but not highlighted by view-mode) are skipped. > > This clearly was a design choice, rather than a bug. However, the > documentation doesn't mention this, and I think it is counterintuitive. > Attaching a very simple patch to fix. [...] > - (move-to-window-line (if (< times 0) 0 -1))) If this was a design choice, then we should perhaps ask the person who designed it what it's all about... which isn't easy in this instance, since this is very old code. Does anybody have an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no