From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 18131@debbugs.gnu.org
Subject: bug#18131: 24.4.50; View-search-... skips all matches between (point) and edge of window
Date: Tue, 23 Feb 2016 23:26:13 +1100 [thread overview]
Message-ID: <87bn77oboa.fsf@gnus.org> (raw)
In-Reply-To: <878undtl18.fsf@secretsauce.net> (Dima Kogan's message of "Mon, 28 Jul 2014 11:06:59 -0700")
Dima Kogan <dima@secretsauce.net> writes:
> The emacs view-mode has navigation with 'n' and 'p' keys to navigate by
> searching (like isearch, but with fewer keystrokes and very similar to
> less and vi).
>
> I just discovered that unlike less and vi, this view-mode navigation
> doesn't hit all the matches, but rather skips the ones between (point)
> and the edge of the window. This ensures that any matches that are
> visible by the user (but not highlighted by view-mode) are skipped.
>
> This clearly was a design choice, rather than a bug. However, the
> documentation doesn't mention this, and I think it is counterintuitive.
> Attaching a very simple patch to fix.
[...]
> - (move-to-window-line (if (< times 0) 0 -1)))
If this was a design choice, then we should perhaps ask the person who
designed it what it's all about... which isn't easy in this instance,
since this is very old code.
Does anybody have an opinion here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-23 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 18:06 bug#18131: 24.4.50; View-search-... skips all matches between (point) and edge of window Dima Kogan
[not found] ` <handler.18131.B.14065708586384.ack@debbugs.gnu.org>
2014-07-28 18:26 ` bug#18131: patch update Dima Kogan
2016-02-23 12:26 ` Lars Ingebrigtsen [this message]
2016-12-25 6:43 ` bug#18131: 24.4.50; View-search-... skips all matches between (point) and edge of window Dima Kogan
2019-06-25 22:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn77oboa.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=18131@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).