From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.bugs Subject: bug#23105: 25.0.92; map-put does not change its argument MAP Date: Thu, 24 Mar 2016 19:04:08 +0100 Message-ID: <87bn63oiqv.fsf@petton.fr> References: <87y4976f8y.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1458842726 18219 80.91.229.3 (24 Mar 2016 18:05:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2016 18:05:26 +0000 (UTC) Cc: 23105@debbugs.gnu.org To: Michael Heerdegen , Sho Takemori Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 24 19:05:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aj9d9-00015d-8y for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 19:05:11 +0100 Original-Received: from localhost ([::1]:52167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj9d7-0006d9-VK for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 14:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj9d4-0006bt-Co for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj9d0-0005we-DF for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj9d0-0005wa-9S for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aj9d0-0006SC-0P for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 14:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2016 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23105-submit@debbugs.gnu.org id=B23105.145884265324737 (code B ref 23105); Thu, 24 Mar 2016 18:05:01 +0000 Original-Received: (at 23105) by debbugs.gnu.org; 24 Mar 2016 18:04:13 +0000 Original-Received: from localhost ([127.0.0.1]:36440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aj9cC-0006Qv-W4 for submit@debbugs.gnu.org; Thu, 24 Mar 2016 14:04:13 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aj9cB-0006Qn-Aa for 23105@debbugs.gnu.org; Thu, 24 Mar 2016 14:04:11 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0FD26217CF for <23105@debbugs.gnu.org>; Thu, 24 Mar 2016 14:04:11 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Thu, 24 Mar 2016 14:04:11 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=dhVy4fx3iukJvVtmj042/HJhzpQ=; b=nPCyK d0S0UnciacW1ZbgoYurYIqNFIjYt9wcwNiuVdwS030MCx2BwVoHZBJxDkbq1eo57 LVyTEK/Zh2+XMO8kHtx4x1sfwDorHZXmrpYTzldeng0ew7KdJc0xNz6M5qbRe0Vd Y9Xaynrh03ZlW/o8dBCxLZANeBawjTwA2uQi5w= X-Sasl-enc: /vM8ZnavUC63wxvMxlEcVzP3V4WB/77BjnLLd5Ms7w02 1458842650 Original-Received: from blueberry (89-156-196-194.rev.numericable.fr [89.156.196.194]) by mail.messagingengine.com (Postfix) with ESMTPA id 38D47C00016; Thu, 24 Mar 2016 14:04:10 -0400 (EDT) In-Reply-To: <87y4976f8y.fsf@web.de> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115449 Archived-At: --=-=-= Content-Type: text/plain Michael Heerdegen writes: > Sho Takemori writes: > >> By expanding map-put, I found that it returns a new list if "m" is a >> list and the key is not in "m". > > Indeed, good catch. > > The implementation of `map-put' is wrong: it binds the evaluated place > expression to a new symbol and uses that symbol as place to operate on. > > The intention presumably was to avoid code duplication in the macro > expansion - which is good - but it fails to change the original place. Now that I have a second look at it, I don't see why `map-put' (and `map-delete' for that matter) are macros. I'll see if I can replace them with functions and have all the tests green. Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - http://gpgtools.org iQEcBAEBCAAGBQJW9CwYAAoJECM1h6R8IHkQELYH/06k6AK3E4R7Hj2BzIrXVj0z HHCcLXcAOxyyfo+VJeTlfLtdeW7NUfa9j3BErGQLGoHTnhJnVFRpBf9s/MhcR9y+ n+cbLNEsMVU+8KJD5+9/KCxtKH4h1HZMN1Q8wOFJnhd/60YIzBBBEAbtc8b6nvRA jm5sDNYILtOTU0SX+6TMPZ44wMOx/BL+4J1rRQdv06l1UfE1oOPQEBIAqub0SVfQ /M0QHmky8APjSr9HXCQTZ8w9rgyGLxtuhk9LQ0mmQ7Scptr68Rqj4WrI7qZfMsl5 DKYaG8FIh7D6vwyXg0CZ+oxOteso94pQgKw3UKqUDm2+WfUo6bi2tt8Di7RhXYE= =C7Qs -----END PGP SIGNATURE----- --=-=-=--