From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M- Date: Thu, 28 Apr 2016 19:26:13 +0200 Message-ID: <87bn4t7ih6.fsf@gnus.org> References: <584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com> <87eh3ba7s9.fsf@building.gnus.org> <877fhuej87.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461864442 14841 80.91.229.3 (28 Apr 2016 17:27:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Apr 2016 17:27:22 +0000 (UTC) Cc: 12535@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 28 19:27:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avpiY-0005P7-5R for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 19:27:10 +0200 Original-Received: from localhost ([::1]:50327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avpiX-0002U8-7D for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Apr 2016 13:27:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avpiT-0002RV-9E for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avpiQ-0006gj-IY for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avpiQ-0006gY-FI for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1avpiQ-0008N8-9l for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2016 13:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2016 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12535 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12535-submit@debbugs.gnu.org id=B12535.146186437732122 (code B ref 12535); Thu, 28 Apr 2016 17:27:02 +0000 Original-Received: (at 12535) by debbugs.gnu.org; 28 Apr 2016 17:26:17 +0000 Original-Received: from localhost ([127.0.0.1]:53487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avphh-0008M2-1I for submit@debbugs.gnu.org; Thu, 28 Apr 2016 13:26:17 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:32828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avphf-0008Lu-ME for 12535@debbugs.gnu.org; Thu, 28 Apr 2016 13:26:16 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avphd-0005Yn-9p; Thu, 28 Apr 2016 19:26:15 +0200 In-Reply-To: (Drew Adams's message of "Wed, 24 Feb 2016 07:15:00 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117105 Archived-At: Drew Adams writes: >> >> > ! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$" >> >> > word)))) >> >> > (setq key (list (intern word)))) >> >> > ((or (equal word "REM") (string-match "^;;" word)) >> >> > --- 708,714 ---- >> >> > (substring word (match-beginning 3) >> >> > (match-end 3)))) >> >> > (not (string-match >> >> > ! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$" >> >> >> >> There's probably a missing | in the patch... >> > >> > Yes, good catch. Should be \\|TAB, not \\TAB. >> >> Can you submit a new patch, preferably tested? > > Sorry; I really don't have the time now. But I think that all > of the relevant info has been provided, so you should be able > to DTRT. The patch is quite tiny. And it is unlikely that > the `edmacro-parse-keys' has changed much, if at all, since > 2014. Just change \\TAB to \\|TAB in the patch. The patch you sent obviously hadn't been tested, because it was syntactically wrong. I'm not going to apply patches that haven't been tested. Please create a new patch and post it here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no