From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 12535@debbugs.gnu.org
Subject: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
Date: Thu, 28 Apr 2016 19:26:13 +0200 [thread overview]
Message-ID: <87bn4t7ih6.fsf@gnus.org> (raw)
In-Reply-To: <ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default> (Drew Adams's message of "Wed, 24 Feb 2016 07:15:00 -0800 (PST)")
Drew Adams <drew.adams@oracle.com> writes:
>> >> > ! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
>> >> > word))))
>> >> > (setq key (list (intern word))))
>> >> > ((or (equal word "REM") (string-match "^;;" word))
>> >> > --- 708,714 ----
>> >> > (substring word (match-beginning 3)
>> >> > (match-end 3))))
>> >> > (not (string-match
>> >> > ! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
>> >>
>> >> There's probably a missing | in the patch...
>> >
>> > Yes, good catch. Should be \\|TAB, not \\TAB.
>>
>> Can you submit a new patch, preferably tested?
>
> Sorry; I really don't have the time now. But I think that all
> of the relevant info has been provided, so you should be able
> to DTRT. The patch is quite tiny. And it is unlikely that
> the `edmacro-parse-keys' has changed much, if at all, since
> 2014. Just change \\TAB to \\|TAB in the patch.
The patch you sent obviously hadn't been tested, because it was
syntactically wrong. I'm not going to apply patches that haven't been
tested.
Please create a new patch and post it here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-04-28 17:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>
[not found] ` <<87eh3ba7s9.fsf@building.gnus.org>
[not found] ` <<ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
[not found] ` <<877fhuej87.fsf@gnus.org>
[not found] ` <<ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
[not found] ` <<87bn4t7ih6.fsf@gnus.org>
[not found] ` <<2493efa4-e079-446c-8926-f7ee14c04ec9@default>
[not found] ` <<87eg9oa7kp.fsf@gnus.org>
[not found] ` <<m3k1d76qgn.fsf@gnus.org>
[not found] ` <<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>
[not found] ` <<8736ji3vgs.fsf@gmail.com>
[not found] ` <<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>
[not found] ` <<83r2717si6.fsf@gnu.org>
2012-09-28 21:37 ` bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB> Drew Adams
2014-02-10 4:52 ` Lars Ingebrigtsen
2014-02-10 5:02 ` Drew Adams
2016-02-24 6:05 ` Lars Ingebrigtsen
2016-02-24 15:15 ` Drew Adams
2016-04-28 17:26 ` Lars Ingebrigtsen [this message]
2016-04-29 0:32 ` Drew Adams
2016-04-29 13:05 ` Lars Ingebrigtsen
2019-06-27 14:41 ` Lars Ingebrigtsen
2019-06-27 16:21 ` Drew Adams
2019-07-07 12:00 ` Noam Postavsky
2019-07-07 15:34 ` Drew Adams
2019-07-07 15:51 ` Eli Zaretskii
2020-10-14 5:18 ` Drew Adams
[not found] ` <de9af715-ee6a-463e-9d91-4ae753f49c00@default>
2020-10-14 14:59 ` Eli Zaretskii
[not found] <<<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>
[not found] ` <<<87eh3ba7s9.fsf@building.gnus.org>
[not found] ` <<<ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
[not found] ` <<<877fhuej87.fsf@gnus.org>
[not found] ` <<<ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
[not found] ` <<<87bn4t7ih6.fsf@gnus.org>
[not found] ` <<<2493efa4-e079-446c-8926-f7ee14c04ec9@default>
[not found] ` <<<87eg9oa7kp.fsf@gnus.org>
[not found] ` <<<m3k1d76qgn.fsf@gnus.org>
[not found] ` <<<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>
[not found] ` <<<8736ji3vgs.fsf@gmail.com>
[not found] ` <<<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>
[not found] ` <<<83r2717si6.fsf@gnu.org>
[not found] ` <<de9af715-ee6a-463e-9d91-4ae753f49c00@default>
[not found] ` <<83o8l4zwda.fsf@gnu.org>
2020-10-14 16:13 ` Drew Adams
2020-10-14 16:28 ` Eli Zaretskii
2020-10-16 4:07 ` Richard Stallman
2020-10-16 6:08 ` Eli Zaretskii
[not found] <<<<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>
[not found] ` <<<<87eh3ba7s9.fsf@building.gnus.org>
[not found] ` <<<<ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
[not found] ` <<<<877fhuej87.fsf@gnus.org>
[not found] ` <<<<ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
[not found] ` <<<<87bn4t7ih6.fsf@gnus.org>
[not found] ` <<<<2493efa4-e079-446c-8926-f7ee14c04ec9@default>
[not found] ` <<<<87eg9oa7kp.fsf@gnus.org>
[not found] ` <<<<m3k1d76qgn.fsf@gnus.org>
[not found] ` <<<<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>
[not found] ` <<<<8736ji3vgs.fsf@gmail.com>
[not found] ` <<<<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>
[not found] ` <<<<83r2717si6.fsf@gnu.org>
[not found] ` <<<de9af715-ee6a-463e-9d91-4ae753f49c00@default>
[not found] ` <<<83o8l4zwda.fsf@gnu.org>
[not found] ` <<1d10d47c-2777-4c8f-89a3-e2693262391c@default>
[not found] ` <<83blh4zs93.fsf@gnu.org>
2020-10-14 17:22 ` Drew Adams
2020-10-14 17:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn4t7ih6.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=12535@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).