From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block Date: Fri, 03 Jun 2016 10:58:14 +0800 Message-ID: <87bn3j7zcp.fsf@gmail.com> References: <87lh2vo7s6.fsf@gmail.com> <87shx23830.fsf@gmail.com> <87wpmcwn13.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1464922764 28498 80.91.229.3 (3 Jun 2016 02:59:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Jun 2016 02:59:24 +0000 (UTC) Cc: 23632@debbugs.gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 03 04:59:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b8fKK-00074Q-Hp for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jun 2016 04:59:12 +0200 Original-Received: from localhost ([::1]:51506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8fKJ-0000ja-G4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Jun 2016 22:59:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8fKD-0000jJ-BY for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 22:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8fKA-00050V-92 for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 22:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8fKA-00050Q-51 for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 22:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b8fK9-00023Y-N9 for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 22:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jun 2016 02:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23632-submit@debbugs.gnu.org id=B23632.14649227337889 (code B ref 23632); Fri, 03 Jun 2016 02:59:01 +0000 Original-Received: (at 23632) by debbugs.gnu.org; 3 Jun 2016 02:58:53 +0000 Original-Received: from localhost ([127.0.0.1]:52207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8fK1-00023B-4w for submit@debbugs.gnu.org; Thu, 02 Jun 2016 22:58:53 -0400 Original-Received: from mail-pa0-f53.google.com ([209.85.220.53]:36120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8fJz-00022z-Rw for 23632@debbugs.gnu.org; Thu, 02 Jun 2016 22:58:52 -0400 Original-Received: by mail-pa0-f53.google.com with SMTP id te7so6882142pab.3 for <23632@debbugs.gnu.org>; Thu, 02 Jun 2016 19:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eRD0QnBmsfWfIBksjskGkpV3RHm1QrUXnNBd9o2HCBE=; b=b6WYG1ZWuj+ggy5zX2wyN88Bbv3+o5aEs2UIhyAur2qtE5982bBDK9eGHuIlISzRx5 POaSeENjrmfq9YGmG6N2IVNxBuBLuSHtYEGRqd1crNS3MD35ng1kvjS75rHzNBaMfmS9 YJrTBvvCENFNil6rsVP0c+1PJPBF1JYkQhCUqROTo46rLg2WKSDNT9zejAA2YciNfJck WphpcRd/lmXwadu1f6HrEDJhg9nZgJTxQ+UJnal5DNBXdPo6OSHYUcwufs6flFFr13i/ guB/JYt3kGSnKLf3wQdT/csPNI97M0w69s/6WNTsSdCzrUeCZUAtNmPVIsD91bHJW/zI pOgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=eRD0QnBmsfWfIBksjskGkpV3RHm1QrUXnNBd9o2HCBE=; b=luN+drsRjKy3x51bOalMkL609Fvl2t+d5WP5GWO3Ve6cliVa3CCwvjCRIo0Zk647Ux NV2H+R830IPeDL7eovetG2dmQy/iax2oULGoFAuQXmkdfmNuFEczlSanQtQdBe16D5jw c4M4k1X26jBlZTo3k1oSSQcP5suBPGmOpSBtEovTNZot8wbcvcq9Eu5kBU7OSTm3Py7H JZaxP5QyuCwitOuQJWTcIzbbC+aDrdCc65/5PRgFbY3cb7+vJEkcHY9BdWnokcDDQt2r Xyyi+TGHHaaYNJTJ1yQyw8myTMeir/YaJRgm8rWtibvVSOCU6RPHg4nFLq8X1613Gd8j tIpQ== X-Gm-Message-State: ALyK8tIXP4Xhhm8oyQhztsTnbGcZXVMMOqP2MNx1tzfi58bY6eCNvHANhqYoztdGfaxI5Q== X-Received: by 10.66.62.196 with SMTP id a4mr1871122pas.25.1464922725750; Thu, 02 Jun 2016 19:58:45 -0700 (PDT) Original-Received: from tsparkle ([155.69.16.255]) by smtp.gmail.com with ESMTPSA id p4sm1456094pac.1.2016.06.02.19.58.44 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2016 19:58:44 -0700 (PDT) In-Reply-To: <87wpmcwn13.fsf@russet.org.uk> (Phillip Lord's message of "Sun, 29 May 2016 22:51:36 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119000 Archived-At: phillip.lord@russet.org.uk (Phillip Lord) writes: > In and off itself, the patch seems fine, but my concern is that that > the previous heuristic did the right thing, the new heuristic does > not. If you've found three instances where it's causing a problem, > then there will be others also. You mentioned "the new heuristic" and "the old system", but to be clear, this behavior is not a new one. I can reproduce it in Emacs 24.3, and it probably goes back farther than that. Also, the solution needs to handle the case where the user switches from the minibuffer back to the original buffer and does some editing, including possible calling undo. The undo boundaries thus created ought to be preserved. Only the undo boundary created specially for completing-read ought to be automatically removed.