From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25529: diagnosis and one approach to a fix Date: Mon, 06 Feb 2017 10:27:34 -0700 Message-ID: <87bmuf8c1l.fsf@tromey.com> References: <87wpd58ag6.fsf@tromey.com> <87shnt89be.fsf@tromey.com> <87o9yg8qdi.fsf@tromey.com> <87k2948onb.fsf@tromey.com> <183374a4-6469-44af-6ae6-fec02874547a@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486402103 8262 195.159.176.226 (6 Feb 2017 17:28:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Feb 2017 17:28:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) Cc: Tom Tromey , 25529@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 06 18:28:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1can5H-0001cV-CT for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Feb 2017 18:28:11 +0100 Original-Received: from localhost ([::1]:49819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1can5M-0000kn-V2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Feb 2017 12:28:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1can5B-0000i9-AR for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2017 12:28:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1can58-0004P4-79 for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2017 12:28:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59812) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1can58-0004Ou-0F for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2017 12:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1can57-0001Fs-MC for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2017 12:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2017 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25529 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25529-submit@debbugs.gnu.org id=B25529.14864020754813 (code B ref 25529); Mon, 06 Feb 2017 17:28:01 +0000 Original-Received: (at 25529) by debbugs.gnu.org; 6 Feb 2017 17:27:55 +0000 Original-Received: from localhost ([127.0.0.1]:58011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1can51-0001FY-J5 for submit@debbugs.gnu.org; Mon, 06 Feb 2017 12:27:55 -0500 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:46265) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1can4z-0001FK-Jf for 25529@debbugs.gnu.org; Mon, 06 Feb 2017 12:27:54 -0500 Original-Received: (qmail 15621 invoked by uid 0); 6 Feb 2017 17:27:43 -0000 Original-Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy7.mail.unifiedlayer.com with SMTP; 6 Feb 2017 17:27:43 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id hVTd1u0072f2jeq01VTgFc; Mon, 06 Feb 2017 10:27:43 -0700 X-Authority-Analysis: v=2.1 cv=H5NInYoi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n2v9WMKugxEA:10 a=JlnJdhbEixGRL0der6IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Sx7+n79FKarWda5I1n5kqPGuKVOSn+sK1SQ30kNl+Q8=; b=SnTuxx1GZ5ZHdWKcBpSR8Qboet KsBvJeo9gwVEnqm5a1tGLs15Ls4mD4BL3dWA5RFc7pmO0zcrlZczc/a1DSoKpRruXEHOab9zqKbpy iiWjoKLm4JLHd1rfhls8apciG; Original-Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:34884 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1can4i-0003QJ-Ut; Mon, 06 Feb 2017 10:27:37 -0700 X-Attribution: Tom In-Reply-To: <183374a4-6469-44af-6ae6-fec02874547a@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Feb 2017 03:12:31 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1can4i-0003QJ-Ut X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:34884 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129037 Archived-At: Dmitry> This is very good, thank you. Here's just one example I've come so far Dmitry> that works with the old code, but not with yours: Dmitry> let x = /[/]/; Dmitry> And that's probably just because the new js-syntax-propertize-regexp Dmitry> doesn't move point forward after matching Yep, adding a goto-char at the end of the function fixed this. Thanks for pointing that out; I'll add a test case for it. Dmitry> We could try to combine the regexps together, though. Then we'd move Dmitry> the syntax-ppss status check inside the rule for the opening Dmitry> delimiter, and use a simple one for the closer. I think I understand combining the regexps. But what does using a simple regexp for the closer mean? Also, what is the purpose of the first call to js-syntax-propertize-regexp in js-syntax-propertize? Tom