From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures Date: Wed, 15 Mar 2017 20:49:21 -0400 Message-ID: <87bmt259m6.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1489625362 31696 195.159.176.226 (16 Mar 2017 00:49:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 16 Mar 2017 00:49:22 +0000 (UTC) Cc: evgenysw@gmail.com To: 26037@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 16 01:49:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJbK-0007EA-Vq for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Mar 2017 01:49:11 +0100 Original-Received: from localhost ([::1]:40175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coJbQ-0005GB-Vb for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Mar 2017 20:49:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coJbF-0005Ek-GK for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coJbC-0005Wh-AG for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:49:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59524) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1coJbC-0005WZ-4g for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1coJbB-0005YX-Ui for bug-gnu-emacs@gnu.org; Wed, 15 Mar 2017 20:49:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2017 00:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26037-submit@debbugs.gnu.org id=B26037.148962529121279 (code B ref 26037); Thu, 16 Mar 2017 00:49:01 +0000 Original-Received: (at 26037) by debbugs.gnu.org; 16 Mar 2017 00:48:11 +0000 Original-Received: from localhost ([127.0.0.1]:57720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJaN-0005X9-0L for submit@debbugs.gnu.org; Wed, 15 Mar 2017 20:48:11 -0400 Original-Received: from mail-io0-f169.google.com ([209.85.223.169]:34635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coJaL-0005Wv-2X for 26037@debbugs.gnu.org; Wed, 15 Mar 2017 20:48:09 -0400 Original-Received: by mail-io0-f169.google.com with SMTP id b140so32245145iof.1 for <26037@debbugs.gnu.org>; Wed, 15 Mar 2017 17:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version; bh=Z+rg6D/skEO8D3lOzpuuImePqcbBzMZf43pHVgJT5i0=; b=bZH+oHec/mDVnlHHJ0Fb+/6DQuMPVrBlRO4iAeYCQO3f/PQWtArTi2WK5IVqWf/rvZ gL/z0lGFrG7yc/NKk1qKVNYWn70PIzyL/KiLezV9PI7ZY6Owa7684DtteolIlBsg+eTX oZc8S1bkYQJNdLbZqOqnzjobcocffxFN4tE4FMMjXcQYZ10xm05xsYqul9fcxeARkEMo LNhGWCfGRVT0MT8QDeBGXQWnflxIsKOnGt/XM03OMT3i2gNOvtTMQRX7g0Gp8XTlVC5V tMEt08YzOB58yRxbS7UlEbujTCjs0d3Opi7kangmvjMP4ay/Cu5k60u12OAOUJp06Yot PJHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version; bh=Z+rg6D/skEO8D3lOzpuuImePqcbBzMZf43pHVgJT5i0=; b=SttBh6JZZptw8M3/ifA9nFEtDuAQo6s++u2BRVULn2sX5iPyc+8GI/a4sp2vQ8STui gGnG0i81qJbDzD41SHUz8lvtxMgWonEs1jLP63+QiLFwBwHxTPlGyn0CIa/JV7mHunvV FB4dO/VQ15KtKO8jkTFUP8xrRa118+uq99AL98r1D02OU8i8uvB0sny4Lkv/K+fID9XR /SiRJs1vz40uUjVctmaTddBOdtAFH9Ue13fao4oBKiKk7aTZ24N2uZmi4y6a1gv+EvWu GsWMtWqfSQ291VnaMOoZKfuvXUruQuzaOwaEsIlf/UrN1An62RHN2EUB4XA5Kzev3UXu Qz9g== X-Gm-Message-State: AFeK/H2YgQ/3b6zzgye3Yd0v98ocYooDNrgjGkq2nxigGOekbDtO4idKehccNm9E1iJZhg== X-Received: by 10.107.180.145 with SMTP id d139mr8170975iof.101.1489625283434; Wed, 15 Mar 2017 17:48:03 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f196sm307473itc.2.2017.03.15.17.48.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Mar 2017 17:48:02 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130635 Archived-At: --=-=-= Content-Type: text/plain [Please use Reply All to keep 26037@debbugs.gnu.org on CC] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Sender: evgenysw@gmail.com Received: by 10.25.157.82 with HTTP; Wed, 15 Mar 2017 03:00:32 -0700 (PDT) In-Reply-To: <87k27r5m1i.fsf@users.sourceforge.net> References: <87k27r5m1i.fsf@users.sourceforge.net> From: Evgeni Kolev Date: Wed, 15 Mar 2017 12:00:32 +0200 X-Google-Sender-Auth: 2FgKjsy98sxtsnj7vXkCQs33HjE Message-ID: Subject: Re: bug#26037: 25.1; perl-mode add syntax support for subroutine signatures To: npostavs@users.sourceforge.net X-Spam-Score: -0.3 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (evgenysw[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.46 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.2 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1co5jx-0002ob-Bt MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="====-=-=" --====-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline OK, I see. After a bit of testing with C-u C-x =, I see that with my proposed change the sigils in 'sub test ($)' will *not* have punctuation class as they did before the chagne. I see these options: 1. I can try to improve the proposed change to preserve backward compatibility - I can try to add another rule which will strictly match only the allowed prototype-sigils $%&*;@[\] 2. discard my proposed change as it might have undesired side effects - at this point, I don't see anything in perl-mode which depends on these prototype-sigils having punctioation class, however, I could be missing something. 3. accept my proposed change as-is, but we must be sure nothing will be broken as a result. I'm sure syntax highlighting will not be broken (I've tested with different themes, different perl sub definitions). Please let me know what you think. --====-=-=-- --=-=-= Content-Type: text/plain I ran git blame against the relevant lines, and turned up Bug#18502. Please check if your change breaks the indentation test case at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=18502#5. --=-=-=--