From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) Date: Sun, 13 Aug 2017 09:21:44 -0400 Message-ID: <87bmnj1u3b.fsf@users.sourceforge.net> References: <20170813005818.GA27146@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502630474 21911 195.159.176.226 (13 Aug 2017 13:21:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Aug 2017 13:21:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Keith David Bershatsky , 21714@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 13 15:21:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgspJ-0005Rq-RY for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 15:21:09 +0200 Original-Received: from localhost ([::1]:49340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgspQ-0006B6-B3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 09:21:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgspG-00069K-Io for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 09:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgspC-00022v-EJ for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 09:21:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgspC-00021y-9y for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dgspC-0003QZ-4V for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2017 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21714-submit@debbugs.gnu.org id=B21714.150263041413133 (code B ref 21714); Sun, 13 Aug 2017 13:21:02 +0000 Original-Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 13:20:14 +0000 Original-Received: from localhost ([127.0.0.1]:59296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgsoQ-0003Pl-8M for submit@debbugs.gnu.org; Sun, 13 Aug 2017 09:20:14 -0400 Original-Received: from mail-it0-f66.google.com ([209.85.214.66]:38871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgsoO-0003Pf-Cn for 21714@debbugs.gnu.org; Sun, 13 Aug 2017 09:20:12 -0400 Original-Received: by mail-it0-f66.google.com with SMTP id f16so6460390itb.5 for <21714@debbugs.gnu.org>; Sun, 13 Aug 2017 06:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nsw9Fo4CVcb7YV+kc2ZaiqDc4Lpa9AvlHQAXdo6Rg/A=; b=XyLNKRY5L0VoThFA4nRCyNnk8D6G4oQZfyeCha4W02FuoogwLdVy5Tus3+k6MkqMXB uIpzpb+fMK/Lk5RURTQJ6yXpfIf6YJ8f3vVcIcrZr/8UYnJIyxtULpmeXRm0YWUgxuc7 XU4UIol9j9b9/MpfrEAUMcHahjtmN5IP8cgqttdfV5Jcwsk9JI5yKsCQvT4mui4qHmbz VNrJ/TiN2s2Pv7RbtsvTsRudzkvk+L5y12J4URZexEh8UJXabr0xFhQg5Gt04vAyVZeE 2sKRh0qjAKdfFkSx6hs0sKyugNEvvFCmPBU/OqvctFt/JIWF2tu08VYOjxeTIXDKwzHm pxUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nsw9Fo4CVcb7YV+kc2ZaiqDc4Lpa9AvlHQAXdo6Rg/A=; b=rdPuTFUEjuTqJmLAySv7SdkczfUCOlbH77RkR3K91gKsvyQsiHHVsm7N5jYGePdoAk DMtK3DvGZVB1WiM6cN1ITeKdKIvkkyqdtXrJpVx/wjmCTTLy8SZuUu8rfFA4H/iIZCz/ qCAg7dmsYz+SNaOtV6IHmfy+E53cHKd6Hba8jBga1B2yHoVgROrc8X3RRozwpiVBJmhf cSdCjP+1x91AXj64MRwjstvLR2/UqiiBnLqXzQ+rDs8SOyPYCeXvM8boQPvYgZb8fkv1 jlvnvCMJnQuo0Cl4C7sOfdlFaS2VyfIlsTU7rc/5brOHdh1Yd+Mvft6or83Tag2SXjm2 c6KA== X-Gm-Message-State: AHYfb5jyhQTDW759x0VTF7A55KhJXJEZhHDM81vQSKp8n1N6YnW/M2Tb nT1cJ6RxZs3X0Q0O X-Received: by 10.36.26.131 with SMTP id 125mr3662037iti.78.1502630406780; Sun, 13 Aug 2017 06:20:06 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id w74sm2503417iow.55.2017.08.13.06.20.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Aug 2017 06:20:06 -0700 (PDT) In-Reply-To: <20170813005818.GA27146@breton.holly.idiocy.org> (Alan Third's message of "Sun, 13 Aug 2017 01:58:18 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135720 Archived-At: Alan Third writes: > +static Lisp_Object > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) > +{ > + Lisp_Object tail; > + > + eassert (valid_image_p (spec)); > + > + for (tail = XCDR (spec); > + CONSP (tail) && CONSP (XCDR (tail)); > + tail = XCDR (XCDR (tail))) > + { > + if (EQ (XCAR (tail), key)) > + { > + if (found) > + *found = 1; > + return XCAR (XCDR (tail)); > + } > + } Wouldn't it be clearer to call Fplist_get here?