From: joaotavora@gmail.com (João Távora)
To: Glenn Morris <rgm@gnu.org>
Cc: 29187@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#29187: flymake ruby and perl tests fail on rhel7.4
Date: Wed, 08 Nov 2017 11:35:47 +0000 [thread overview]
Message-ID: <87bmkd80ks.fsf@gmail.com> (raw)
In-Reply-To: <bhk1z1zgut.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 07 Nov 2017 20:42:02 -0500")
Glenn Morris <rgm@gnu.org> writes:
> João Távora wrote:
>
>> Wow, subtle stuff. My ruby (2.3) doesn't crash. Does yours also fail if
>> you use a absolute path after -wc instead of a relative one?
>
> Still fails.
>
>> So I guess all that's missing is a fix to the ruby case. If the absolute
>> path doesn't fix it, I think we can fake a dummy HOME
>
> This works for me:
>
Thanks. Hmmm, trying to decide if this should be done just for the tests
or in the ruby backend in general. I lean towards your solution, since
this is appars to be a ruby bug anyway. WDYT?
>
> --- i/test/lisp/progmodes/flymake-tests.el
> +++ w/test/lisp/progmodes/flymake-tests.el
> @@ -120,11 +120,17 @@ flymake-tests--wait-for-backends
> (ert-deftest ruby-backend ()
> "Test the ruby backend"
> (skip-unless (executable-find "ruby"))
> - (flymake-tests--with-flymake ("test.rb")
> - (flymake-goto-next-error)
> - (should (eq 'flymake-warning (face-at-point)))
> - (flymake-goto-next-error)
> - (should (eq 'flymake-error (face-at-point)))))
> + ;; Some versions of ruby fail if HOME doesn't exist (bug#29187).
> + (let* ((tempdir (make-temp-file "flymake-tests-ruby" t))
> + (process-environment (cons (format "HOME=%s" tempdir)
> + process-environment)))
> + (unwind-protect
> + (flymake-tests--with-flymake ("test.rb")
> + (flymake-goto-next-error)
> + (should (eq 'flymake-warning (face-at-point)))
> + (flymake-goto-next-error)
> + (should (eq 'flymake-error (face-at-point))))
> + (delete-directory tempdir t))))
>
> (ert-deftest different-diagnostic-types ()
> "Test GCC warning via function predicate."
next prev parent reply other threads:[~2017-11-08 11:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 23:44 bug#29187: flymake ruby and perl tests fail on rhel7.4 Glenn Morris
2017-11-07 0:25 ` Dmitry Gutov
2017-11-07 0:45 ` João Távora
2017-11-07 1:35 ` Glenn Morris
2017-11-07 15:57 ` João Távora
2017-11-07 17:22 ` Dmitry Gutov
2017-11-07 19:02 ` Glenn Morris
2017-11-07 19:08 ` Glenn Morris
2017-11-07 22:58 ` João Távora
2017-11-08 1:42 ` Glenn Morris
2017-11-08 11:35 ` João Távora [this message]
2017-11-08 19:35 ` Glenn Morris
2017-11-09 20:21 ` João Távora
2017-11-07 10:21 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmkd80ks.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=29187@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).