From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#29225: Tramp backup-by-copying in a Converting ACL Invalid argument error on Windows 7 Date: Fri, 10 Nov 2017 13:41:04 +0100 Message-ID: <87bmkal31b.fsf@gmx.de> References: <83lgjfqsjt.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1510317737 5821 195.159.176.226 (10 Nov 2017 12:42:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Nov 2017 12:42:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Shuguang Sun , 29225@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 10 13:42:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD8dL-00010M-65 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 13:42:07 +0100 Original-Received: from localhost ([::1]:41357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD8dQ-0003So-V3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 07:42:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eD8dK-0003SY-Tf for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 07:42:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eD8dG-0006mr-WF for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 07:42:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eD8dG-0006mL-Sf for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 07:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eD8dG-0000JZ-Gz for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2017 07:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2017 12:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29225-submit@debbugs.gnu.org id=B29225.15103176761147 (code B ref 29225); Fri, 10 Nov 2017 12:42:02 +0000 Original-Received: (at 29225) by debbugs.gnu.org; 10 Nov 2017 12:41:16 +0000 Original-Received: from localhost ([127.0.0.1]:33295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD8cW-0000IR-5z for submit@debbugs.gnu.org; Fri, 10 Nov 2017 07:41:16 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:60752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD8cU-0000ID-9B for 29225@debbugs.gnu.org; Fri, 10 Nov 2017 07:41:14 -0500 Original-Received: from detlef.gmx.de ([79.140.124.106]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUI8w-1eeBe41GPS-00R1uJ; Fri, 10 Nov 2017 13:41:06 +0100 In-Reply-To: <83lgjfqsjt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Nov 2017 19:18:46 +0200") X-Provags-ID: V03:K0:KaLA650gtWckZcCRY2ILw8fDizlKG5Fcns1JoOGlPGh6235UPPk KFvyAZEGEeHz4/gRm+ZBggKox1nRuDfuscIDidX5qB2/cYqHqmjl3vu7AsdL4EkFGryVnof NO2mJRPr07hzbnUbWAYRjiiZLONtVVR9li3ER1wnQPVva5D4DjvF4wy5N/v3rIzJ0NY+X5M xW32BUxKgYXg/6PDILznQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ta7FMFT6fsE=:zTlaVONwI4Eo/To7CLbggw jZQMJDEMA8wpZelgdEs8mB35S2kDh34z3zlOshrCL3ZtIJ3SLVfjnBr4J91aQM6/ITpX2+MuS W3s5gA9NrTyXb7KPXrFEqXOVB7+b2TKFH1TtDkvw0rjtA60qwGQmMwIsM+xJPgLnglwI+HD+c rnnytKDL/G4+9eEeclzZIy/f6Oc6sti/tvy31iudNkzmXeSX9yfK93EJakelqN7HjJrqCSOsQ zPfedoI2NVkroJCLbdC7hL1KTvayIebZmODcavRopBjzEEyIIjK3QauthARV6tjiT41vkoG0u CRWV+9uNZg04BNNykbAJXuYnlcMTS6KaB4eVsU/rvcdFeXIqMPMbP71Vv70zhSSzpSWB2P0F5 YLWz3Iyea9m9BNV7/jKPkxZ0fZhvCw/hHuBmU6/yu7LIvZdPKRvKEM4PtkBbt+QNusWQsg5sU wPZWL37f1NGE9f1Gda1T/NiS87MSZDJ2rcQI04RNeas/sme0N8yAZMCS5hiiXvSLXRTwoPW12 eAPNPHmi1Shp4ABFEiXKvMvqWmQuXUyScBxgCgi6wK4MYe34i+mE2xs4k2/qHvkDBRFGS9Hph EcBx3+y0U2iv6shbFVA3nY4STnwYG6rn65/LZmKu97x23nVInSVug7M5kbXns15LMaf+ecBhW YNKNpIOBO9sm13Ik0lQQqB6b3YYR5byiqLjZxa2riPhl6MTjGqFXImUwg4YGTbdIgrZjw3/M5 I0eF+jlHD1QAb6HhjikOWdMeTtOAPk+buyRxRkh6MtHZTxobkOKpIf66CD3jySDWJQC0/+I9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139729 Archived-At: Eli Zaretskii writes: Hi Eli, >> Debugger entered--Lisp error: (file-error "Converting ACL" "Invalid argu= ment" >> "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!= !path!user!Ava!_mortality.R.~1~") >>=20 >> set-file-acl >> ("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!= !!path!user!Ava!_mortality.R.~1~" >> "user::rw-\ngroup::rw-\nother::r--\n") >> set-file-extended-attributes >> ("c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!= !!path!user!Ava!_mortality.R.~1~" >> ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil nil = nil nil))) >> backup-buffer-copy("/plink:user@host:/path/user/Ava/_mortality.R" >> "c:/Users/user/HOME/.emacs.d/autosave/Rfiles/!drive_c!plink!!user@host!!= !path!user!Ava!_mortality.R.~1~" >> 436 ((acl . "user::rw-\ngroup::rw-\nother::r--\n") (selinux-context nil = nil nil nil))) > > This seems to indicate that Unix-style ACLs are passed to native > Windows ACL functions, which won't work. Michael, could you please > look into this? I'd expect ACLs derived from remote files never to be > used on local files. And vice versa. However, Tramp has no chance to do something here. It offers own implementations of `file-acl' and `set-file-acl'; both functions don't know where the returned ACL shall be used (=C2=B4file-acl'), or where the A= CL comes from (`set-file-acl'). Therefore, the docstring of `set-file-acl' says "Value is t if setting of ACL was successful, nil otherwise." The error message "Converting ACL" "Invalid argument" comes from Ffile_acl of fileio.c. It *raises* an error instead of silently returning Qnil, as advertised by the docstring. A similar wrong behaviour I've found in `tramp-smb-handle-set-file-acl'. I would convert both functions to return nil instead of raising an error, in the emacs-26 branch. Any objection? > Thanks. Best regards, Michael.