From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Date: Mon, 05 Feb 2018 23:17:38 +0200 Organization: LINKOV.NET Message-ID: <87bmh3w2z1.fsf@mail.linkov.net> References: <87d28rt4jl.fsf@telefonica.net> <874lmxloo1.fsf@mail.linkov.net> <87d11kquw2.fsf@mail.linkov.net> <83fu6g860d.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517866511 12158 195.159.176.226 (5 Feb 2018 21:35:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2018 21:35:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 19045@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 05 22:35:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eioOx-000074-Os for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 22:34:11 +0100 Original-Received: from localhost ([::1]:39515 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eioQy-0002di-Us for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 16:36:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eioQo-0002dG-AF for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 16:36:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eioQk-0005Hv-D7 for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 16:36:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51206) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eioQk-0005Hp-8e for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 16:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eioQj-0006RD-V1 for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 16:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Feb 2018 21:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19045 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19045-submit@debbugs.gnu.org id=B19045.151786655024717 (code B ref 19045); Mon, 05 Feb 2018 21:36:01 +0000 Original-Received: (at 19045) by debbugs.gnu.org; 5 Feb 2018 21:35:50 +0000 Original-Received: from localhost ([127.0.0.1]:59100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eioQY-0006Qb-5G for submit@debbugs.gnu.org; Mon, 05 Feb 2018 16:35:50 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:42276 helo=homiemail-a20.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eioQW-0006QT-7M for 19045@debbugs.gnu.org; Mon, 05 Feb 2018 16:35:48 -0500 Original-Received: from homiemail-a20.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTP id AD06A7EC064; Mon, 5 Feb 2018 13:35:47 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-107-8.cust.tele2.ee [91.129.107.8]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPSA id DB49A7EC063; Mon, 5 Feb 2018 13:35:46 -0800 (PST) In-Reply-To: <83fu6g860d.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Feb 2018 05:33:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142951 Archived-At: >> > Too bad that a new useful customizable variable >> > vc-git-print-log-follow is not mentioned in NEWS.26. >> > >> > It works quite well, but only with the following fix >> > that puts more restrictions - it checks not only >> > for a directory, but also if it is a single file. >> > >> > The whole patch is intended for the emacs-26 branch: >> >> Pushed to the emacs-26 branch. > > Please don't push anything to the release branch without John's or > mine explicit approval. As things are, I'm very busy these days, and > didn't yet have time to review the patch thoroughly, so I'm not sure > I'm happy with its being pushed. Sorry, will wait more time the next time. >> diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el >> index b0d2221..efdd29e 100644 >> --- a/lisp/vc/vc-dispatcher.el >> +++ b/lisp/vc/vc-dispatcher.el >> @@ -313,6 +313,8 @@ vc-do-command >> (status 0)) >> (when files >> (setq squeezed (nconc squeezed files))) >> + (let ((inhibit-message t)) >> + (message "Running %s %s" command (vc-delistify squeezed))) >> (let (;; Since some functions need to parse the output >> ;; from external commands, set LC_MESSAGES to C. >> (process-environment (cons "LC_MESSAGES=C" process-environment)) > > I don't understand why would we want to hard-code the fact that these > commands are not shown in the echo area. I don't want to cause more flicker in the echo area when the full command gets overwritten immediately by the truncated command in the echo area.