From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#31699: 26.1.50; find-face-definition defaults to non-face symbol Date: Sun, 03 Jun 2018 19:39:34 +0100 Message-ID: <87bmcrr9y1.fsf@tcd.ie> References: <87fu23ra9l.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1528051088 24702 195.159.176.226 (3 Jun 2018 18:38:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2018 18:38:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 31699@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 20:38:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXtD-0006MV-L0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 20:38:03 +0200 Original-Received: from localhost ([::1]:36304 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPXvK-0002Ay-Nf for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 14:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPXvD-0002An-D0 for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:40:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPXv8-00007G-9U for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:40:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPXv8-000075-3z for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPXv7-0000Iq-TW for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2018 14:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2018 18:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31699-submit@debbugs.gnu.org id=B31699.15280511861137 (code B ref 31699); Sun, 03 Jun 2018 18:40:01 +0000 Original-Received: (at 31699) by debbugs.gnu.org; 3 Jun 2018 18:39:46 +0000 Original-Received: from localhost ([127.0.0.1]:60547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXur-0000IH-Pv for submit@debbugs.gnu.org; Sun, 03 Jun 2018 14:39:45 -0400 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:33211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPXup-0000I1-Mv for 31699@debbugs.gnu.org; Sun, 03 Jun 2018 14:39:44 -0400 Original-Received: by mail-wm0-f41.google.com with SMTP id z6-v6so11484260wma.0 for <31699@debbugs.gnu.org>; Sun, 03 Jun 2018 11:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=qsTRfo6vRvI8ISOyXrWnMmfi7UnY8An5Vt3utSXJ9n4=; b=uUUdfDIl6IBZOOSmn1DgJoyivW2kHpLb9I9TBuAEqLbRf8GbaZkKsnlayWVGzWFkTg CQ3DY85bMxU0EffQg5u+ScNYctG+sFqcFwXV2UZZfEzOdJEMt0d3Byvb/GCMoUTnVI8v uMbdSdOXOYykMW1lV/SxB6dEzEBm9qM+ktt0SMfhceLjXellmQZuvFy3cqLMBHDfuKIC 76Zi5TvMwjF2+fmfTeTnQ+5D9egrWA4mSnfhvOtlGZCD4HPr5mT738lAr5tVMyQNtI2g 6/H0+0VGFT4k3SD/yT0GLmDki6EAgAMKmr4I7TKa5YS3CxxbW4mdNFoenZWw3a/LS9pN snFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qsTRfo6vRvI8ISOyXrWnMmfi7UnY8An5Vt3utSXJ9n4=; b=dZdva6/N3atWDdjPxo4OnhB8QaU1xsDx9Fup4qmYNLsNc2meNTDwTtnKNRYr7b/D4O Xfy8GD1b7IzLop8yXlt9JNdew+30NhKargZWWrUsrtiSGKAncGLHhPonp8xubnV1GavK 8RiWvc5hFlgwyl6QDh9+ofbpLgBJFPG1EmNYkGcTa2MYUsNqvAFLWw2ez56Dt/1lgFzz UCZehkHQbLMTpHl+0FkIKXtLkOYZsrtXCRwb1/+5Z2dhE39knuKdnprNT6hsZZ9j3559 7v4R22+6PyQ5ztf4nvj2AwQPZsRAOMmK9EAqBBBr02G6rxot27bx+U6F5Ash6JdZbbUg vz1Q== X-Gm-Message-State: ALKqPwdd3z0Dl4uJ8Yk43fTWnWTITF+GmLTPpDT0bbL+GuTcL/iBmF8J 4TitWodSgbOq38ThymvO8n65f7DW X-Google-Smtp-Source: ADUXVKLlp/daKh3aCrL9CY/EPH9ZoPXO8kI1PhHshV9yjCLKNElr/uFRN+QUu2qXpK8aoJ4zAt6xJA== X-Received: by 2002:a50:8c44:: with SMTP id p62-v6mr20949048edp.38.1528051176604; Sun, 03 Jun 2018 11:39:36 -0700 (PDT) Original-Received: from localhost ([213.233.149.2]) by smtp.gmail.com with ESMTPSA id o25-v6sm23998223edq.62.2018.06.03.11.39.35 for <31699@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Jun 2018 11:39:35 -0700 (PDT) In-Reply-To: <87fu23ra9l.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 03 Jun 2018 19:32:38 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146921 Archived-At: --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > Patch to follow. As promised: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-default-candidate-of-find-face-definition.patch >From e129903ed87acedcadef203711b597a880ac36e0 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sun, 3 Jun 2018 19:34:37 +0100 Subject: [PATCH] Fix default candidate of find-face-definition * lisp/emacs-lisp/find-func.el (find-function-read): Use face-at-point instead of variable-at-point for faces. (bug#31699) --- lisp/emacs-lisp/find-func.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index ed8dc74506..13bbd9a7ec 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -464,6 +464,7 @@ find-function-read otherwise uses `variable-at-point'." (let* ((symb1 (cond ((null type) (function-called-at-point)) ((eq type 'defvar) (variable-at-point)) + ((eq type 'defface) (face-at-point t)) (t (variable-at-point t)))) (symb (unless (eq symb1 0) symb1)) (predicate (cdr (assq type '((nil . fboundp) -- 2.17.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=--