From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Drew Adams <drew.adams@oracle.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 15687@debbugs.gnu.org
Subject: bug#15687: 24.3.50; custom themes: disabling does not restore initial configuration
Date: Wed, 13 Jun 2018 19:41:18 +0300 [thread overview]
Message-ID: <87bmce1vwx.fsf@tcd.ie> (raw)
In-Reply-To: <92900c1c-cf89-4679-8f16-4f8171607528@default> (Drew Adams's message of "Fri, 25 Dec 2015 20:28:47 -0800 (PST)")
reopen 15687
quit
Drew Adams <drew.adams@oracle.com> writes:
>> I give up. If you want to remain convinced there is no problem,
>> fine. If you don't want to even try to see the problems reported,
>> using the simple recipe I gave, fine. (Yes, simple to do: download
>> the files, load them into emacs -Q, and try the command. Maybe 3
>> minutes altogether, including the time to download.) ... there
>> seems to be little desire to fix the custom theme code in this
>> regard. So be it.
>>
>> Ok; closing.
>
> There is nothing OK about closing this bug. The bug clearly
> remains, and it is 100% reproducible.
>
> And users of custom themes keep getting tripped up by this
> problem. A common, perhaps the most common, question about
> custom themes is how to completely undo one. IOW, this bug.
I'm sorry if I've misunderstood something after skimming this bug
report, but I think the following recipe, starting from emacs -Q,
illustrates the central issue:
;; Sample custom theme touching user options and faces.
(with-temp-file (expand-file-name "foo-theme.el" custom-theme-directory)
(insert "\
(deftheme foo)
(custom-theme-set-variables 'foo '(text-quoting-style 'curved))
(custom-theme-set-faces 'foo '(default ((t :foreground \"white\"
:background \"black\"))))
(provide-theme 'foo)\n"))
;; Make changes conflicting with theme `foo'.
(setq text-quoting-style 'grave)
(set-foreground-color "green")
;; Load, enable, and disable theme `foo'.
(load-theme 'foo t)
(disable-theme 'foo)
At the end of this, the value of text-quoting-style and the foreground
of the default face are nil and "black", respectively. Wouldn't it be
less intrusive if they were reverted to the values they held before
enabling foo-theme, namely 'grave and "green", respectively?
Feel free to close this bug again if I've misunderstood something.
Thanks,
--
Basil
In GNU Emacs 27.0.50 (build 10, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
of 2018-06-04 built on thunk
Repository revision: 1dafa4a02ed45bb4d02c6dc34c55518858422088
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux buster/sid
next prev parent reply other threads:[~2018-06-13 16:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 20:55 bug#15687: 24.3.50; custom themes: disabling does not restore initial configuration Drew Adams
2013-11-26 2:14 ` Stefan Monnier
2013-11-26 14:05 ` Drew Adams
2013-11-26 20:16 ` Stefan Monnier
2013-11-26 20:44 ` Drew Adams
2013-11-30 8:57 ` Glenn Morris
2013-11-30 17:10 ` Drew Adams
2014-11-05 3:48 ` Drew Adams
2018-06-14 19:53 ` Stefan Monnier
2013-11-26 14:08 ` Drew Adams
2013-11-26 18:47 ` William G. Gardella
2013-11-26 19:01 ` Drew Adams
2013-11-26 19:44 ` W. Greenhouse
2013-11-26 21:16 ` Drew Adams
2015-12-26 1:08 ` Lars Ingebrigtsen
2015-12-26 4:28 ` Drew Adams
2018-06-13 16:41 ` Basil L. Contovounesios [this message]
2018-06-14 20:03 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmce1vwx.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=15687@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).