* bug#31840: and-let* expands to if instead of when
@ 2018-06-15 2:08 Jonas Bernoulli
2018-06-15 4:10 ` Michael Heerdegen
2018-06-21 19:18 ` bug#31840: documentation: Add code of conduct section Gábor Boskovits
0 siblings, 2 replies; 7+ messages in thread
From: Jonas Bernoulli @ 2018-06-15 2:08 UTC (permalink / raw)
To: 31840
(and-let* ((a 'a))
(body-1)
(body-n))
expands to
(let* ((a (and t 'a)))
(if a
(body-1)
(body-n)))
but according to its doc-string ("Like `when-let*'...")
it is supposed to expand to
(let* ((a (and t 'a)))
(if a
(progn
(body-1)
(body-n))))
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#31840: and-let* expands to if instead of when
2018-06-15 2:08 bug#31840: and-let* expands to if instead of when Jonas Bernoulli
@ 2018-06-15 4:10 ` Michael Heerdegen
2018-06-19 1:30 ` Mark Oteiza
2018-06-21 19:18 ` bug#31840: documentation: Add code of conduct section Gábor Boskovits
1 sibling, 1 reply; 7+ messages in thread
From: Michael Heerdegen @ 2018-06-15 4:10 UTC (permalink / raw)
To: Jonas Bernoulli; +Cc: Mark Oteiza, 31840
Jonas Bernoulli <jonas@bernoul.li> writes:
> (and-let* ((a 'a))
> (body-1)
> (body-n))
>
> expands to
>
> (let* ((a (and t 'a)))
> (if a
> (body-1)
> (body-n)))
>
> but according to its doc-string ("Like `when-let*'...")
> it is supposed to expand to
>
> (let* ((a (and t 'a)))
> (if a
> (progn
> (body-1)
> (body-n))))
Good catch.
Looks like a typo - the `if' should just be a `when'. Mark, can you
have a look?
Thanks,
Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread* bug#31840: and-let* expands to if instead of when
2018-06-15 4:10 ` Michael Heerdegen
@ 2018-06-19 1:30 ` Mark Oteiza
2018-06-19 5:52 ` Michael Heerdegen
0 siblings, 1 reply; 7+ messages in thread
From: Mark Oteiza @ 2018-06-19 1:30 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: Jonas Bernoulli, 31840
On 15/06/18 at 06:10am, Michael Heerdegen wrote:
> Jonas Bernoulli <jonas@bernoul.li> writes:
>
> > (and-let* ((a 'a))
> > (body-1)
> > (body-n))
> >
> > expands to
> >
> > (let* ((a (and t 'a)))
> > (if a
> > (body-1)
> > (body-n)))
> >
> > but according to its doc-string ("Like `when-let*'...")
> > it is supposed to expand to
> >
> > (let* ((a (and t 'a)))
> > (if a
> > (progn
> > (body-1)
> > (body-n))))
>
> Good catch.
>
> Looks like a typo - the `if' should just be a `when'. Mark, can you
> have a look?
Oh my… I agree, changed in 5b9cc150
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#31840: documentation: Add code of conduct section
2018-06-15 2:08 bug#31840: and-let* expands to if instead of when Jonas Bernoulli
2018-06-15 4:10 ` Michael Heerdegen
@ 2018-06-21 19:18 ` Gábor Boskovits
2018-06-21 19:27 ` Gábor Boskovits
1 sibling, 1 reply; 7+ messages in thread
From: Gábor Boskovits @ 2018-06-21 19:18 UTC (permalink / raw)
To: 31840-done
[-- Attachment #1: Type: text/plain, Size: 46 bytes --]
Already fixed as #31841. Closing and merging.
[-- Attachment #2: Type: text/html, Size: 67 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-21 19:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-15 2:08 bug#31840: and-let* expands to if instead of when Jonas Bernoulli
2018-06-15 4:10 ` Michael Heerdegen
2018-06-19 1:30 ` Mark Oteiza
2018-06-19 5:52 ` Michael Heerdegen
2018-06-19 11:38 ` Mark Oteiza
2018-06-21 19:18 ` bug#31840: documentation: Add code of conduct section Gábor Boskovits
2018-06-21 19:27 ` Gábor Boskovits
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).