unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 27114@debbugs.gnu.org, agrambot@gmail.com
Subject: bug#27114: 25.2: fringe click echoes "Emacs-Lisp:" in emacs-lisp mode
Date: Tue, 17 Jul 2018 21:45:48 -0400	[thread overview]
Message-ID: <87bmb58gfn.fsf@gmail.com> (raw)
In-Reply-To: <m2lgm9paoe.fsf@aurox.ch> (Charles A. Roelli's message of "Thu, 24 Aug 2017 11:38:57 +0200")

tags 27114 fixed
close 27114 27.1
quit

>> > > (If you make the proposed change, and then visit some .el file and
>> > > click C-mouse-3, what do you see in the header of the pop-up menu?)
>> > 
>> > I still see "Emacs-Lisp Mode" (it's unchanged).  Notice that Alex's
>> > change removes the "overall prompt" from the "main" Emacs Lisp mode
>> > keymap, but not the menu-map.
>> 
>> Then maybe I was confused, and Alex's patch is TRT.
>
> It seems correct, especially in light of the docstring of make-keymap:
>
> (make-keymap &optional STRING)
> [...]
> The optional arg STRING supplies a menu name for the keymap
> in case you use it as a menu with ‘x-popup-menu’.

I pushed it to master.

[1: 1c79d15863]: 2018-07-17 21:40:59 -0400
  Remove menu name from emacs-lisp-mode-map (Bug#27114)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1c79d15863b768fe3156647a54d03a90688dd361





  reply	other threads:[~2018-07-18  1:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28  9:46 bug#27114: 25.2: fringe click echoes "Emacs-Lisp:" in emacs-lisp mode Charles A. Roelli
2017-05-30 23:16 ` npostavs
2017-05-31  6:23   ` Eli Zaretskii
2017-08-09 23:07     ` Alex
2017-08-20 14:14       ` Charles A. Roelli
2017-08-20 14:58         ` Eli Zaretskii
2017-08-21 13:20           ` Charles A. Roelli
2017-08-21 14:37             ` Eli Zaretskii
2017-08-24  9:38               ` Charles A. Roelli
2018-07-18  1:45                 ` Noam Postavsky [this message]
2017-10-01  4:25               ` Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmb58gfn.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=27114@debbugs.gnu.org \
    --cc=agrambot@gmail.com \
    --cc=charles@aurox.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).