From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32504: [PATCH] syntax-is-{comment|string}-p Date: Fri, 24 Aug 2018 22:26:51 -0400 Message-ID: <87bm9ruqok.fsf@gmail.com> References: <87o9dup3ow.fsf@gmail.com> <871sapwzbp.fsf@gmail.com> <87lg8xtexb.fsf@gmail.com> <83a7pdb2x4.fsf@gnu.org> <87d0u7n3r0.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535163912 5113 195.159.176.226 (25 Aug 2018 02:25:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 25 Aug 2018 02:25:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32504@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 25 04:25:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftOGA-0001An-HS for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Aug 2018 04:25:06 +0200 Original-Received: from localhost ([::1]:44360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftOIG-000762-Mb for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Aug 2018 22:27:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ftOI6-00075l-OB for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2018 22:27:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ftOI2-0001SB-Ni for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2018 22:27:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55100) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ftOI2-0001Rr-Jf for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2018 22:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ftOI2-00057t-Cj for bug-gnu-emacs@gnu.org; Fri, 24 Aug 2018 22:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Aug 2018 02:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32504-submit@debbugs.gnu.org id=B32504.153516402119699 (code B ref 32504); Sat, 25 Aug 2018 02:27:02 +0000 Original-Received: (at 32504) by debbugs.gnu.org; 25 Aug 2018 02:27:01 +0000 Original-Received: from localhost ([127.0.0.1]:60118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftOI1-00057f-EJ for submit@debbugs.gnu.org; Fri, 24 Aug 2018 22:27:01 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:39836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftOHz-00057P-B6 for 32504@debbugs.gnu.org; Fri, 24 Aug 2018 22:26:59 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id t69-v6so4256118itb.4 for <32504@debbugs.gnu.org>; Fri, 24 Aug 2018 19:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AYZQo0OITzYKWlRrQt2c80y9ILnVFpAcn9GsZfmB6Q0=; b=BaFzt36bw54CqGcW7ZwKE9oLPHyfZ7kbSa7low62p2DeeJ/Gx3yxQeZl6ImWkGLseA HQcZJGmOlKcAt/h/ym9Gha9GLWT6UTbYs6vd9vcxtYNsABbVhR6cGfNqN9rLmhg/rH8D FKFlnXtjFyjjZrCeYrKwzgOFbgf8lEsE9OHXBkfWNwpH9C51odukBMtSzj+63FTG1Zx7 r7mvzsAAk//qFgGlKSRGcamZzZdFLA6HPMZ+VngJKwT/swqlUIWlfHGL1r+HXWCYGgoZ OzZwmvsEJXR0y5kbVX1dH2es1jtBz1FmMD55xKgttIu72r+1O7BmIFpXLFBLhuYi/ngr JCGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AYZQo0OITzYKWlRrQt2c80y9ILnVFpAcn9GsZfmB6Q0=; b=jmkkG9iQnRyd4ZXkpzEv2FpfyscpWSUKj4qcCJeyZQss7absYaltEVVOiluJDo9Rod 550163gIUi9z1gzzaa4SN8lnSAJ0KMLC/5pbbgfjMIyLMP5tUcIK9DuSI6DCOiwZaAci n4lrdU1sKjhdJNjAgcjNICgqmjFbFPe9pmbTA6WmvhloXUURCG6hT6RhIy/d/Yl+UcxI 23QKQom0EyBRlR5Y1g3YMtmJL82fqZ0Nq4DH74Oz1MB9V86KthDfxCjsya/yx1FLL/mw gY0Zl6ZV3GCSDDZKZyMswYJtj011+QoeR3Sl6/MPXE+VoDXzjx4PR9TP6V+ePV6dKtus SsVA== X-Gm-Message-State: APzg51B1afQLNohbVOPBk3+ylBX1/1JCX8w71xr8OGyITP27hks2gFiL R4r6CUUHHbH9K3nQwUBS+DwLHdeg X-Google-Smtp-Source: ANB0VdbxVLACmOvkKAz4GkcWIgIXSxBVWSScFcFTWKtx93BozI/ZW1tnH8yIpfs2E9y2OmJ6HSPMPQ== X-Received: by 2002:a24:be8f:: with SMTP id i137-v6mr220936itf.113.1535164013625; Fri, 24 Aug 2018 19:26:53 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k5-v6sm2932680ioj.59.2018.08.24.19.26.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Aug 2018 19:26:52 -0700 (PDT) In-Reply-To: <87d0u7n3r0.fsf@gmail.com> (Alex Branham's message of "Fri, 24 Aug 2018 11:11:47 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149737 Archived-At: Alex Branham writes: >>> Thanks, I didn't know about syntax-ppss-context. It doesn't seem to be >>> documented anywhere. >> >> If it's useful, we could document it. > > I'm ambivalent about its usefulness - I don't see it used anywhere in > Emacs's code and only once in the packages I have installed. For a bit of prior art, there are some similar functions in python.el: python-syntax-context, python-syntax-context-type, python-syntax-comment-or-string-p, python-syntax-closing-paren-p. Also, syntax.el has a couple of commented out "XEmacs compatibility functions": buffer-syntactic-context, buffer-syntactic-context-depth. I think it would make sense to provide symbolic names for all the elements returned by syntax-ppss, maybe like this: (cl-defstruct (syntax-state (:constructor nil) (:type list)) depth list-start sexp-end string-start comment quoted min-depth comment-style comment-or-string-start open-parens syntax-sequence)