From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Tue, 25 Dec 2018 22:35:23 +0200 Organization: LINKOV.NET Message-ID: <87bm59tkuk.fsf@mail.linkov.net> References: <878t18j4is.fsf@mail.linkov.net> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> <09b2c002-1519-61dd-6e8b-2e87794077e2@yandex.ru> <87zht1jjdf.fsf@mail.linkov.net> <75267609-e167-c26e-82e8-d6c2609dbf30@yandex.ru> <8736qrkgel.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545771075 12062 195.159.176.226 (25 Dec 2018 20:51:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2018 20:51:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33567@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 25 21:51:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbtfS-000305-2A for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 21:51:10 +0100 Original-Received: from localhost ([127.0.0.1]:42983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbthY-0002dP-CD for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 15:53:20 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbthK-0002cH-49 for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbthG-0002Wr-RZ for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbthG-0002Wb-OX for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbthG-0002j6-N0 for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Dec 2018 20:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154577116110411 (code B ref 33567); Tue, 25 Dec 2018 20:53:02 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 25 Dec 2018 20:52:41 +0000 Original-Received: from localhost ([127.0.0.1]:36457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbtgu-0002hr-TL for submit@debbugs.gnu.org; Tue, 25 Dec 2018 15:52:41 -0500 Original-Received: from firebrick.maple.relay.mailchannels.net ([23.83.214.59]:33853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbtgr-0002hf-8F for 33567@debbugs.gnu.org; Tue, 25 Dec 2018 15:52:38 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BD0544217B; Tue, 25 Dec 2018 20:52:35 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (unknown [100.96.30.62]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 86CE041A87; Tue, 25 Dec 2018 20:52:35 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 25 Dec 2018 20:52:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Whimsical-Minister: 27eeed344412c9ea_1545771155636_643440917 X-MC-Loop-Signature: 1545771155636:1621097477 X-MC-Ingress-Time: 1545771155635 Original-Received: from pdx1-sub0-mail-a16.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a16.g.dreamhost.com (Postfix) with ESMTP id 33B987F932; Tue, 25 Dec 2018 12:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=W4DczYGRAtMX6pfKcjbeDmUvcas=; b= B7rg0ytOzM4G400mQhips4hd24asUzKlsni3NvkZCfrhvkOnS7qKtbWpM2cwoOR8 MibZu6I9zyJMvv5Axi4QDEGBOj0Jbw01vePnIJfNjf3dFpLiel30H9eBOu+FBuGe 3+aUsEYzR4Jbk7soCr9Ya4B2btZ+/kmxljbDy0Vz3iA= Original-Received: from mail.jurta.org (m91-129-108-193.cust.tele2.ee [91.129.108.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a16.g.dreamhost.com (Postfix) with ESMTPSA id 7538D7F925; Tue, 25 Dec 2018 12:52:32 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a16 In-Reply-To: (Dmitry Gutov's message of "Mon, 24 Dec 2018 04:29:39 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudekfedgudegiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepledurdduvdelrddutdekrdduleefnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtkedrudelfedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegughhuthhovheshigrnhguvgigrdhruhenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153842 Archived-At: > Speaking of ttys, green and red look foreground looks kind of okay for me > in that context. However, diff-refine-* faces are simply defined > as :inverse-video. And now, with the new feature, when e.g. there is a face > that spans the whole line (like a comment), both diff-refine-added and > diff-refine-removed faces look the same. Which is a problem. I don't have > easy suggestions except defining specific background for them instead of > inverse-video. And at that point we can drop the green/red foregrounds if > people prefer. What do you think about this solution that combines both green/red foreground colors with syntax colors: https://gist.github.com/skanev/0eeb943e3111a1df55fd