From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35506: 27.0.50; Emacs hangs while interrupting tramp processes Date: Sat, 04 May 2019 18:36:15 +0200 Message-ID: <87bm0ii3cw.fsf@gmx.de> References: <87y33rzalc.fsf@gmail.com> <875zqs7xe6.fsf@gmx.de> <87zho2e1cg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="17045"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35506@debbugs.gnu.org To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 04 18:37:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMxez-0004JR-Ff for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 18:37:13 +0200 Original-Received: from localhost ([127.0.0.1]:58768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMxey-0006Mp-GT for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 12:37:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMxep-0006LH-Jz for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMxeo-0007Tb-Lv for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMxeo-0007TN-HA for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMxeo-00022E-8O for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35506 X-GNU-PR-Package: emacs Original-Received: via spool by 35506-submit@debbugs.gnu.org id=B35506.15569877907777 (code B ref 35506); Sat, 04 May 2019 16:37:02 +0000 Original-Received: (at 35506) by debbugs.gnu.org; 4 May 2019 16:36:30 +0000 Original-Received: from localhost ([127.0.0.1]:52079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMxeI-00021N-4L for submit@debbugs.gnu.org; Sat, 04 May 2019 12:36:30 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:45231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMxeE-000216-MK for 35506@debbugs.gnu.org; Sat, 04 May 2019 12:36:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556987780; bh=1dKc72oHjcM5TO9USQ6hSH3ATmI8R7zdxUSBG4TRP5Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=h97CyWwqQox0Yu85jJwO3/Wox6YKZIiXasyb9ejx76Xh2MC1TgTF8NTpYzTpIF2GM IfEsEyuAm+EPSndwWerw0TWojzNY3JwAnWqbHOxiMbAoHPBgidi7CmSOj+uqo0zT2V TyfmMODbwKvegfvlJhqJvH5bKR1A1mf8eR09J/Iw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.57.229]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfHAB-1gq4Tb41JT-00grLh; Sat, 04 May 2019 18:36:20 +0200 In-Reply-To: <87zho2e1cg.fsf@gmail.com> (John Shahid's message of "Sat, 04 May 2019 10:33:19 -0400") X-Provags-ID: V03:K1:FjXeTItCd1S6cvnffyU/oCMnkDNle/+sU/khMqbSrjmS9HNt8g4 7idLHjP5CTVo0kM1pJcQYbq2nfNbzPiCsTAV9xKn0U4xP4dXVsY40JyeDlrU4slErFxkVJf B0uLx6pkDi/7s+ThFoXy3J4zx+qssZKrsJ9HmwdXk1uDu29DneYKguGmS0esbHlfW/kfLmy 1fsT+6WFyzCP/Z1bgr+tw== X-UI-Out-Filterresults: notjunk:1;V03:K0:kdgE9QF1sgI=:w2Xu/SkUlHDzvFAe0u/fI5 EpTVNqK5yTgI5V1jpFkBiqye8KF93arRf46nA+DpFQz+eHBQZAFFxcRDB29pESasgpBy+7aE1 Mtb1n8CSPEb9HmOAzKhkcdj8FQZNO+5DB6mkzN4nAbJxZ+csKGgHwMLAWFLM9r4HiVmWP2inO qfc49ksJrRxlNHO+19QEWHI0fAtmAJHkpO8nwXE5tZktqCtHXFAtp/TIQ2e19OJ0Hew/LO2Fw s/tdplyuGPW6VatG+HuTNiaEFnhXDgTggodbOty/iMmi9NY9Gq3MgXODAbNr1gRsvU4DSWVbs gkm0/yku/b3m0XISU/Y8bTPBg96C3adxPPozF12LehWQvJjMmzgJMd09N9Vg8ZgkG/v7nvPpX 5KqmG6Xtr8ZF5sHmJ1shvLJ6FZ38bMhYwz7DvpsbEYoX0uUnZss7N88rf7c3i0sgOtsc/mdwD 26T3RvoK+VRq9PPeD2bV8Waaq6/2OPmv0zsgTr22hAiBDpr2+BzzNkCegN26AXuX2mwubJ8tE zu1nltrsqYmJSr9m1lqh0qekoE1K7JhwUCjHxfZbrGxNcs5qPrTbP+yowvzjki2VnPs6E0mkF 6I6g6GCkw8nNoY3uEu+Cp9imsDPbnBAolxPzzc+KTsnA2vpNUTAeDE4MF2kb+ZNIDRDkoKb2V dYveg+bBkH3zZ5HlXGZBHlac9aLvxHsAUc/Nuar29QvEwK/gTrk0qE0yh1sz4/jL4gb7zZd/Z st5lCDgQZn4GSTjU7uIdip9m7WhzIp2x9h5Aa11WY6ZmDYvfvbQO8Puth71nN6ehOZpleSEr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158746 Archived-At: John Shahid writes: Hi John, >> So your patch is correct, pls push. > > Thanks for reviewing the patch. Unfortunately, I don't have push access > to the repository. Do you mind pushing the patch for me? Done, pushed to master. > 1. Asynchronously kill the process (the first patch) > 2. Always return success, e.g. return proc. > > It doesn't make sense to use the default interrupt function for remote > processes anyway, so always succeeding seems like the right thing to do > here. This begs the question, why do we have to wait for the process > output at all? Well, the caller wants to know whether `interrupt-process' succeeded. >> So we must investigate, why `interrupt-process' does not return in >> your case. > > That is a good point. I didn't look deeply into why the `with-timeout' > isn't timing out in my case. I will try to understand what is going on > in the next few days. IIRC, `tramp-accept-process-output' suppresses timers. So we might change the code to (untested) ;; Wait, until the process has disappeared. If it doesn't, ;; fall back to the default implementation. (and (tramp-accept-process-output proc 1) ;; Report success. proc))))) Does this work for you? > Cheers, > > JS Best regards, Michael.