From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35476: font-lock-{append, prepend}-text-property and anonymous faces Date: Tue, 14 May 2019 08:01:04 +0200 Message-ID: <87bm05inhb.fsf@gmail.com> References: <87lfzu9hsl.fsf@gmail.com> <87a7g8owim.fsf@gmail.com> <87ftpqq1kl.fsf_-_@gmail.com> <87a7frj1qg.fsf_-_@gmail.com> <87d0knshkm.fsf@gmail.com> <87v9ydg87m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="152260"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35476@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 14 08:02:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQQVy-000dSr-Ih for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 08:02:14 +0200 Original-Received: from localhost ([127.0.0.1]:39826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQQVw-0006Xq-J1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2019 02:02:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQQVn-0006XM-Lq for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 02:02:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQQVm-0000fe-IK for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 02:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33392) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQQVm-0000fN-Er for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 02:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQQVm-0005Tm-8B for bug-gnu-emacs@gnu.org; Tue, 14 May 2019 02:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2019 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 35476-submit@debbugs.gnu.org id=B35476.155781367720981 (code B ref 35476); Tue, 14 May 2019 06:02:02 +0000 Original-Received: (at 35476) by debbugs.gnu.org; 14 May 2019 06:01:17 +0000 Original-Received: from localhost ([127.0.0.1]:46933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQQV3-0005SK-C5 for submit@debbugs.gnu.org; Tue, 14 May 2019 02:01:17 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:51704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQQV1-0005S7-G5 for 35476@debbugs.gnu.org; Tue, 14 May 2019 02:01:16 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id o189so1435846wmb.1 for <35476@debbugs.gnu.org>; Mon, 13 May 2019 23:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=DiTd2397WgI6ec83YrNyvbx/KeDyWQ32fCmmCWD/hWA=; b=Uw7/X+TZgEGD4x2N3JQAXkQUpXRMx/+kZcCLzZaiGQIzLpAkPScmOu7SmeMCmlH1ss WjIPSMd2sSDALVVH1s3XlPULIXVuFGdSqNCmwsAajvQvRJYb5WDP32qWp7UDxIW2LQH4 /rHLnomsoqsg2xdhP9p8abxC3OfXjn9q7zg5mcRU9pvjWmKjbuMRZfEV8VwxCenvkjOF CNrb9TNNU8EtI/3Fu+cMVHghPSdg4/t6KxgPWMUYruo1pFYRslFyVxOxHYKZopZWXpBR 7lwpwSSFme68aPinb1wozHG2WbffWLr11JK/hJjNyXoOFIhViJ0XjloLEMZEAWTURk5q aDew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DiTd2397WgI6ec83YrNyvbx/KeDyWQ32fCmmCWD/hWA=; b=RhHu9UJywzdCKg0T70D/UQdf/AdAdKjePel+q0JpEQ/AypK9f1GtVSvkjGsU997iBc O4AHv6v31OJiqjBQbOBx9jhZtX3kFfdAeFoFLlg0Thu/ZV3SOy5D49mb8SXqWwSsCWFG +HlYJDV9Ua3bAGAcHvFwlCykRcPxzcMa0RD50cjMMGHPVEjQtF/H58uUusY5a36bCIF0 9MnLzoJN7kGCo0aIC1sMBvmRHnN9eogm0qIqcFyFKrolPOglO/nv45vb361F4EGYs2dq DhOjr8hRf0EvA44j/zNehrbAOZT+kr487xODswo0XWFx9ipBEYjnCtgqu/n+If+B/smi q7ew== X-Gm-Message-State: APjAAAWNQyAy6AgmWngjIMFMI2pHAHgooSR2zBbQu3K1fdpQW7L7CW2p dV2qyeZjptTNRDuWs67O3eFzZXbA X-Google-Smtp-Source: APXvYqxlAYluJtYOWEwjYYdD3YXKlweRWMDWBlm2TyGkJJr3ACJTNRvtbM8EdaZPJvefvsLZxC++7w== X-Received: by 2002:a1c:20c9:: with SMTP id g192mr17466698wmg.76.1557813669409; Mon, 13 May 2019 23:01:09 -0700 (PDT) Original-Received: from nc10-laptop (71.142.13.109.rev.sfr.net. [109.13.142.71]) by smtp.gmail.com with ESMTPSA id a15sm20018491wru.88.2019.05.13.23.01.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 23:01:07 -0700 (PDT) In-Reply-To: <87v9ydg87m.fsf@gmail.com> (Noam Postavsky's message of "Mon, 13 May 2019 21:01:33 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159248 Archived-At: Noam Postavsky writes: > K=C3=A9vin Le Gouguec writes: > >> [1] Although running 'make lisp/font-lock-tests' in the test/ folder >> fails on the append test. Could it be that the Makefile runs the >> tests against the old font-lock.el that is installed on my system, >> rather than the new one in my repository? I took a look at the >> test_template in test/Makefile, but I could not understand what the >> machinery loads at a glance. > > I forgot to answer this before. There's two issues here: > > 1. The default value of load-prefer-newer means that of you change a .el > file without recompiling it, Emacs will load the .elc file instead. > > 2. For font-lock.el in particular, it's preloaded, so even if you > recompile it, font-lock.elc isn't loaded again, you need to redump > Emacs. Duly noted, I'll watch out for that in the future. > So generally, the way to test changes is > > make && make -C test font-lock-tests > > Although it should also work to load the modified .el file explicitly > (untested, but): > > make -C test EMACS_EXTRAOPT=3D'-l font-lock.el' font-lock-tests Just tried with and without EMACS_EXTRAOPT, and it does seem to work around the problem. >> Can e.g. git-show(1) understand action stamps? I glanced at >> gitrevisions(7) but nothing suggests Git knows anything about this >> format. > > I don't think so. The last time I brought this up on emacs-devel there > was some suggestion that cgit (a git web frontend) would learn to > recognize them eventually, but I'm not sure if anything is really moving > in that direction. > >> (Or, going the opposite route, maybe the git-log-to-ChangeLog machinery >> could translate hashes to action stamps?) > > Maybe, although personally, as a human reader, I prefer date+title to > both hashes and action stamps, even when reading from git. Yes, it's > quicker to find a commit given a hash, but that still requires at least > pressing RET or clicking or something like that. Quite often, just > seeing the title is enough to understand what's meant and I don't need > to dig further. OK. FWIW, since I like to give context to my messages and I expect to be doing the hash =E2=86=A6 date+title dance a lot, this command seems to d= o the job adequately for commit $c: git show --no-patch --date=3Dshort --format=3Dformat:'%ad "%s"' $c Now to write some Lisp to make that available from vc and magit buffers=E2= =80=A6 (one-liner for action stamps left as exercise to the reader) > I think we're good here, pushed to master. Thanks!