From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 36644@debbugs.gnu.org
Subject: bug#36644: Git log search
Date: Tue, 16 Jul 2019 01:27:40 +0300 [thread overview]
Message-ID: <87blxvj5lv.fsf@mail.linkov.net> (raw)
In-Reply-To: <eacebe8e-808f-c58a-aee9-1ad0c35c0bd7@yandex.ru> (Dmitry Gutov's message of "Mon, 15 Jul 2019 18:05:20 +0300")
>> It would be very useful to have the command to grep git logs,
>> for instance, to search commits by bug numbers in format "bug#36789"
>> and many other such use cases:
>
> I like the idea.
Thanks for the review. Installed to master after fixing
according to your comments.
>> +;; - log-search (pattern)
>> +;;
>> +;; Search for PATTERN in the revision log.
>
> Is pattern a regexp or a verbatim string? That should be documented.
Fixed to use string.
> Git supports regexps, but maybe we should look at what other backends
> can support as well.
It seems the most compatible type is string.
> I wonder if the format of the output should be specified as well.
> E.g. by saying that it's the same as for print-log, long version.
Fixed by saying it's long version.
Should it support short format as well?
>> +(defun vc-git-log-search (buffer pattern)
>> + (vc-setup-buffer buffer)
>> + (vc-git-command
>> + buffer 'async nil
>> + "log"
>> + "--no-color" "-i" (format "--grep=%s" pattern)))
>
> Should this use shell-quote-argument?
Fixed to use shell-quote-argument.
Should it have a key binding?
For example, `vc-log-incoming' is bound to `C-x v I',
`vc-log-outgoing' is bound to key `C-x v O', so logically
`vc-log-search' would be bound to `C-x v s', but unfortunately
it's already taken by `vc-create-tag'.
next prev parent reply other threads:[~2019-07-15 22:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 22:27 bug#36644: Git log search Juri Linkov
2019-07-15 15:05 ` Dmitry Gutov
2019-07-15 22:27 ` Juri Linkov [this message]
2019-07-16 14:25 ` Dmitry Gutov
2019-07-16 14:44 ` Andreas Schwab
2019-07-16 15:08 ` Robert Pluim
2019-07-16 20:20 ` Juri Linkov
2019-07-16 22:31 ` Noam Postavsky
2019-07-18 22:35 ` Juri Linkov
2019-07-24 14:57 ` Dmitry Gutov
2019-07-16 20:15 ` Juri Linkov
2019-07-18 15:01 ` Dmitry Gutov
2019-07-18 15:12 ` Robert Pluim
2019-07-18 18:02 ` Dmitry Gutov
2019-07-18 18:11 ` Robert Pluim
2019-07-18 22:32 ` Juri Linkov
2019-07-24 15:10 ` Dmitry Gutov
2019-07-24 15:46 ` Robert Pluim
2019-07-24 15:53 ` Dmitry Gutov
2019-07-24 16:13 ` Eli Zaretskii
2019-07-25 12:36 ` Dmitry Gutov
2019-07-25 13:08 ` Eli Zaretskii
2019-07-25 13:20 ` Dmitry Gutov
2019-07-25 13:37 ` Robert Pluim
2019-07-25 19:00 ` Juri Linkov
2019-07-25 18:55 ` Juri Linkov
2019-07-25 21:26 ` Dmitry Gutov
2019-07-25 21:38 ` Juri Linkov
2019-07-24 16:13 ` Robert Pluim
2019-07-24 17:04 ` Eli Zaretskii
2019-07-24 23:22 ` Juri Linkov
2019-07-25 12:44 ` Dmitry Gutov
2019-07-25 18:50 ` Juri Linkov
2019-07-25 19:19 ` Dmitry Gutov
2019-07-29 22:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blxvj5lv.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=36644@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).