* bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found @ 2016-12-04 22:59 Drew Adams 2019-07-27 11:43 ` Lars Ingebrigtsen 0 siblings, 1 reply; 5+ messages in thread From: Drew Adams @ 2016-12-04 22:59 UTC (permalink / raw) To: 25114 Some of the Isearch code (e.g. `isearch-lazy-highlight-search') uses the return value of `isearch-search-string' as a Boolean value. The doc string should say that it returns nil if STRING is not found. In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=/c/usr --host=i686-pc-mingw32' ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found 2016-12-04 22:59 bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found Drew Adams @ 2019-07-27 11:43 ` Lars Ingebrigtsen 2019-07-27 16:16 ` Drew Adams 0 siblings, 1 reply; 5+ messages in thread From: Lars Ingebrigtsen @ 2019-07-27 11:43 UTC (permalink / raw) To: Drew Adams; +Cc: 25114 Drew Adams <drew.adams@oracle.com> writes: > Some of the Isearch code (e.g. `isearch-lazy-highlight-search') > uses the return value of `isearch-search-string' as a Boolean value. > The doc string should say that it returns nil if STRING is not found. This seems like it was fixed by 65575c24aaa in 2016. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found 2019-07-27 11:43 ` Lars Ingebrigtsen @ 2019-07-27 16:16 ` Drew Adams 2019-07-27 16:31 ` Noam Postavsky 2019-07-27 16:35 ` Eli Zaretskii 0 siblings, 2 replies; 5+ messages in thread From: Drew Adams @ 2019-07-27 16:16 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: 25114 > > Some of the Isearch code (e.g. `isearch-lazy-highlight-search') > > uses the return value of `isearch-search-string' as a Boolean value. > > The doc string should say that it returns nil if STRING is not found. > > This seems like it was fixed by 65575c24aaa in 2016. Good. It's not fixed in Emacs 26, at least, which is what the bug report references. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found 2019-07-27 16:16 ` Drew Adams @ 2019-07-27 16:31 ` Noam Postavsky 2019-07-27 16:35 ` Eli Zaretskii 1 sibling, 0 replies; 5+ messages in thread From: Noam Postavsky @ 2019-07-27 16:31 UTC (permalink / raw) To: Drew Adams; +Cc: 25114, Lars Ingebrigtsen fixed 25114 25.1 quit Drew Adams <drew.adams@oracle.com> writes: >> > Some of the Isearch code (e.g. `isearch-lazy-highlight-search') >> > uses the return value of `isearch-search-string' as a Boolean value. >> > The doc string should say that it returns nil if STRING is not found. >> >> This seems like it was fixed by 65575c24aaa in 2016. > > Good. It's not fixed in Emacs 26, at least, which is > what the bug report references. The fix [1: 65575c24aa] is included in 25.1. [1: 65575c24aa]: 2016-01-20 15:09:09 +0200 Fix doc string of 'isearch-search-fun-function' https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=65575c24aaad9bedf6b84cc062cc03fbe4dd1315 ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found 2019-07-27 16:16 ` Drew Adams 2019-07-27 16:31 ` Noam Postavsky @ 2019-07-27 16:35 ` Eli Zaretskii 1 sibling, 0 replies; 5+ messages in thread From: Eli Zaretskii @ 2019-07-27 16:35 UTC (permalink / raw) To: Drew Adams; +Cc: 25114, larsi > Date: Sat, 27 Jul 2019 09:16:18 -0700 (PDT) > From: Drew Adams <drew.adams@oracle.com> > Cc: 25114@debbugs.gnu.org > > > This seems like it was fixed by 65575c24aaa in 2016. > > It's not fixed in Emacs 26, at least Yes, it is. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-27 16:35 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-04 22:59 bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found Drew Adams 2019-07-27 11:43 ` Lars Ingebrigtsen 2019-07-27 16:16 ` Drew Adams 2019-07-27 16:31 ` Noam Postavsky 2019-07-27 16:35 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).