From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#25114: 24.5; doc of `isearch-search-string' should say it returns nil if STRING not found Date: Sat, 27 Jul 2019 12:31:13 -0400 Message-ID: <87blxfv3qm.fsf@gmail.com> References: <576d1ed9-6f0a-466f-8e4d-99b1d32263fc@default> <87v9vnitxw.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191986"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: 25114@debbugs.gnu.org, Lars Ingebrigtsen To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 18:32:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrPcA-000npQ-IW for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 18:32:10 +0200 Original-Received: from localhost ([::1]:46564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrPc9-0000EV-AA for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 12:32:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42840) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrPc6-0000EJ-EN for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 12:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrPc4-0005Li-Dq for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 12:32:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrPc2-0005JC-GY for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrPc2-0002hC-CN for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 12:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 16:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 25114-submit@debbugs.gnu.org id=B25114.156424508810284 (code B ref 25114); Sat, 27 Jul 2019 16:32:02 +0000 Original-Received: (at 25114) by debbugs.gnu.org; 27 Jul 2019 16:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:45278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrPbT-0002fn-PP for submit@debbugs.gnu.org; Sat, 27 Jul 2019 12:31:28 -0400 Original-Received: from mail-io1-f48.google.com ([209.85.166.48]:41304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrPbO-0002eY-Iz; Sat, 27 Jul 2019 12:31:23 -0400 Original-Received: by mail-io1-f48.google.com with SMTP id j5so107042216ioj.8; Sat, 27 Jul 2019 09:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3ensHWHyVjKRB4VPLN4gAIO031j9nSmS738k8lLfCIM=; b=Yrhb+QipzRbEYwn2xKs7CzAKHnVM7plr2ECAQuFd3UYBB5dItV8zF+bG1OVrbAuqOF 3SPZiYZC/adUZEQkxeDn2KU4Z0KWrwnwJXPPRNDGAiG6/WbbdIDa0nlFqN+3z74a/fK3 VNz0odfKaVHF+nOZIwLcYZhnrBTEnZVzcJSN6KF/K5UwrsVwUzZ57JRSTdUuFfFadOpl j5DrBmHMMrARXel7wFO12mDoJ0ibR7nc5Lgbk5qW4yjhytS9c51tj2Bsd+4CIIDsHjaO pQWa1MJ21pmz5DGzPQ1DTjc4p5NyleIrbXvHOo6u/Nw3quPpnE9iFnIxULiOMP+Xt/bn rKcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3ensHWHyVjKRB4VPLN4gAIO031j9nSmS738k8lLfCIM=; b=CAaGnNfCQaGuZ6EXOtOhx09JHJmMW7GyNAFlvHp8SN+3vQWxc9ICQGQP7W0Gps4VXH cZwP0xGpz0/MTcJiaVtrSGJOxsNVcrz3LYEID8zbUBevwU+CsiOz6tDVLNFucZXt/yUj 1nT+gvJyV4UGHCUO7AP+soHQLV6nZSEw/b0jM7h/K4Yk/bLDBeXUXbx9ZjOPM1ap2K/h yXZekj+neG1WtmK4Z5j9OrX5iFO8IrKDPAGgnp9+T2kZCfin889A8275Cyt0DK7Ska5d weVNyNT8DFIIO/BMYXx1A3EwasXwAnoW0OjQeE/rKyueblZy1OSAri9TXREJg4rej7ZF 7iZg== X-Gm-Message-State: APjAAAXO19V3qcy2HzKVP7mAxCBHn93jTBT0v7BY21eF95C/c0waDUpt ILQdK/n/Z+f27Xg9MV49TeWdezL7 X-Google-Smtp-Source: APXvYqx/y2orWCRtAgR7sNc5XCYwEoXYetr5gEXa+bwSnG+95AmkFcZivyi87v1VwV9T4NQpYMw0DQ== X-Received: by 2002:a02:a417:: with SMTP id c23mr32489982jal.141.1564245075372; Sat, 27 Jul 2019 09:31:15 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id j14sm47784606ioa.78.2019.07.27.09.31.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jul 2019 09:31:14 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Sat, 27 Jul 2019 09:16:18 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163895 Archived-At: fixed 25114 25.1 quit Drew Adams writes: >> > Some of the Isearch code (e.g. `isearch-lazy-highlight-search') >> > uses the return value of `isearch-search-string' as a Boolean value. >> > The doc string should say that it returns nil if STRING is not found. >> >> This seems like it was fixed by 65575c24aaa in 2016. > > Good. It's not fixed in Emacs 26, at least, which is > what the bug report references. The fix [1: 65575c24aa] is included in 25.1. [1: 65575c24aa]: 2016-01-20 15:09:09 +0200 Fix doc string of 'isearch-search-fun-function' https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=65575c24aaad9bedf6b84cc062cc03fbe4dd1315