From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36830: 26.2; find-file-visit-truename is not honored as file local variable Date: Sun, 25 Aug 2019 07:39:29 +0200 Message-ID: <87blwdajn2.fsf@gnus.org> References: <87d0hufamm.fsf@gmail.com> <87ftlsfp3v.fsf@gnus.org> <87h8688233.fsf@gmail.com> <874l27btck.fsf@gnus.org> <83d0gvk5m0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251062"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36830@debbugs.gnu.org, gusbrs.2016@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 07:40:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1lG6-0013CV-KW for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 07:40:10 +0200 Original-Received: from localhost ([::1]:40928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1lG4-0004SK-UW for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 01:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52697) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1lFz-0004SE-Fj for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1lFy-0003Oc-BK for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1lFy-0003OT-89 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1lFy-00065h-4c for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 05:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36830 X-GNU-PR-Package: emacs Original-Received: via spool by 36830-submit@debbugs.gnu.org id=B36830.156671157523374 (code B ref 36830); Sun, 25 Aug 2019 05:40:02 +0000 Original-Received: (at 36830) by debbugs.gnu.org; 25 Aug 2019 05:39:35 +0000 Original-Received: from localhost ([127.0.0.1]:43459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1lFX-00064w-ET for submit@debbugs.gnu.org; Sun, 25 Aug 2019 01:39:35 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:57738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1lFV-00064o-SJ for 36830@debbugs.gnu.org; Sun, 25 Aug 2019 01:39:34 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1lFS-0001Tz-7d; Sun, 25 Aug 2019 07:39:32 +0200 In-Reply-To: <83d0gvk5m0.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Aug 2019 23:07:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165799 Archived-At: Eli Zaretskii writes: > I don't think this variable was designed to be set from file-local > variables block. Visiting a file and naming its buffer are two racy > actions, and where there's a race there will be chicken-and-egg type > of problems. [...] > I expect such renaming to cause future bugs, FWIW. Or maybe not, but > this is beyond hacky, IMO. Yes, I think so, too, but: > Maybe we should just document that this variable cannot be file-local. files.el has this: (put 'find-file-visit-truename 'safe-local-variable 'booleanp) It was changed to booleanp in 2007 (from the presumably invalid `boolean'), so it didn't work before 2007 for that reason, and it hasn't worked after 2007 because it's checked too late. So perhaps the fix here is to just remove that `put'? On the other hand, it would be nice if it worked, because it seems like a pretty useful thing to be able to customise on a per-file basis. Perhaps. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no