From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36843: 26.2; ERC lurker feature broken Date: Thu, 05 Sep 2019 19:57:45 -0400 Message-ID: <87blvymh3a.fsf@gmail.com> References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> <871rxao6lc.fsf@gmail.com> <877e6y7k9n.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205132"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: Thibault Polge , 36843@debbugs.gnu.org To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 06 01:58:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i61dj-000rDN-Aj for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Sep 2019 01:58:11 +0200 Original-Received: from localhost ([::1]:50434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i61di-0003RO-7g for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Sep 2019 19:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58368) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i61da-0003R0-TA for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2019 19:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i61dZ-0000Lm-PL for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2019 19:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i61dZ-0000Lh-M9 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2019 19:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i61dZ-0006N8-IY for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2019 19:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2019 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.156772787524476 (code B ref 36843); Thu, 05 Sep 2019 23:58:01 +0000 Original-Received: (at 36843) by debbugs.gnu.org; 5 Sep 2019 23:57:55 +0000 Original-Received: from localhost ([127.0.0.1]:36240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i61dS-0006Md-Rz for submit@debbugs.gnu.org; Thu, 05 Sep 2019 19:57:55 -0400 Original-Received: from mail-io1-f68.google.com ([209.85.166.68]:36381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i61dQ-0006ME-UE; Thu, 05 Sep 2019 19:57:53 -0400 Original-Received: by mail-io1-f68.google.com with SMTP id b136so8806086iof.3; Thu, 05 Sep 2019 16:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GahStc4EaFYfWkeso47uLq3ZHKIbKSb2Uk4/mwxOeR4=; b=E9jJxsBJ3oImEjutPXVnqQN5zz/FJ8yEPNj8f29nIVzyPJ+kTF+7FY1oRWsLA7a8L+ rrvBU+CcMi4AD7gXOnjanxwHqlY3fUM/Egk96wZ98GKwgmVzeoWOa8RL3XYfrgDKic60 9EcNBOexAFVBcmfxxEahg+0SFZPqLB2yxwrgMTIw6jf6EKcF2GjcpHpnf3sp8IkOAZ89 0oFdJV8Qn65BU8iiIgXNpLyNb8ZGRezcAAInpc4KyXgN50RvQ+fMQdXh2KNbzolPutWk M38GrJvoIUS/UhYo6W1SM3PVMK4jswUwBkG05RIU/DTeGmC9+pkHD+KVW4qV6aDAuwnZ 7WOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GahStc4EaFYfWkeso47uLq3ZHKIbKSb2Uk4/mwxOeR4=; b=VB0WismxcSc5Pc6Gg+m5puzTfCRFLCIK2cMMH4C1thhTMXp6QAa8KdxX6CQkCSN9jN xFGIpNoLW0/SXCFkBxtYFDhGx8nbDo8ZiHEhUlCAMmvJrM/HVoYev2/NamAwwpaiI1PE p9IwZGftR5zWbdLbFzRm/muNNBqQJChyoNwL8BgHszXcyjQQue6/9utcQCAMOMvSqqGj r4gbFIIwrc6w9PgJSug78VqbQF6igKePUICeyDceJNQiCUXhAWZ+AURdII3+SeI/37YY GZkVg5JWI31LizH1jsiZicBEUWj3QLE2TokLtm9odWghbA5sVgYjLI8ULqVN0PxCjA6i WdxA== X-Gm-Message-State: APjAAAWK/o3laepmCJ7icjsfQt7qZPyYRSxgEzHnjZUuLhxbKsr5TSlC UKyI3sHT4UWYLlQgL2owfo8l7fBr X-Google-Smtp-Source: APXvYqwxYQjlRs0fy4utO9G6eDq/p3iwefINmJfnTK2b6g1vAJikhaQ7efIbBM0CGCGjgT6y4T5NFg== X-Received: by 2002:a5d:9403:: with SMTP id v3mr6927445ion.281.1567727867135; Thu, 05 Sep 2019 16:57:47 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id u6sm1875273iop.18.2019.09.05.16.57.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Sep 2019 16:57:46 -0700 (PDT) In-Reply-To: <877e6y7k9n.fsf@fencepost.gnu.org> (Amin Bandali's message of "Tue, 27 Aug 2019 10:31:00 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166242 Archived-At: tags 36843 fixed close 36843 27.1 quit Amin Bandali writes: > Subject: [PATCH] Fix erc-lurker-update-status (bug#36843) > > Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding". > > * lisp/erc/erc.el (erc-message-parsed): New variable. > (erc-display-message): Dynamically bind it. > (erc-lurker-update-status): Check it instead of using `parsed' > directly. This results in `erc-lurker-state' being properly updated > to keep track of non-lurkers, and thus `erc-lurker-p' returning > correct results rather than return t for everyone. Pushed to master. ff0f4c7312 2019-09-05T19:56:14-04:00 "Fix erc-lurker-update-status (bug#36843)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ff0f4c731231b03d73cc35de9e042d1fc1b75f4e