From: Noam Postavsky <npostavs@gmail.com>
To: Amin Bandali <bandali@gnu.org>
Cc: Thibault Polge <thibault@thb.lt>, 36843@debbugs.gnu.org
Subject: bug#36843: 26.2; ERC lurker feature broken
Date: Thu, 05 Sep 2019 19:57:45 -0400 [thread overview]
Message-ID: <87blvymh3a.fsf@gmail.com> (raw)
In-Reply-To: <877e6y7k9n.fsf@fencepost.gnu.org> (Amin Bandali's message of "Tue, 27 Aug 2019 10:31:00 -0400")
tags 36843 fixed
close 36843 27.1
quit
Amin Bandali <bandali@gnu.org> writes:
> Subject: [PATCH] Fix erc-lurker-update-status (bug#36843)
>
> Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding".
>
> * lisp/erc/erc.el (erc-message-parsed): New variable.
> (erc-display-message): Dynamically bind it.
> (erc-lurker-update-status): Check it instead of using `parsed'
> directly. This results in `erc-lurker-state' being properly updated
> to keep track of non-lurkers, and thus `erc-lurker-p' returning
> correct results rather than return t for everyone.
Pushed to master.
ff0f4c7312 2019-09-05T19:56:14-04:00 "Fix erc-lurker-update-status (bug#36843)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ff0f4c731231b03d73cc35de9e042d1fc1b75f4e
prev parent reply other threads:[~2019-09-05 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 22:05 bug#36843: 26.2; ERC lurker feature broken Thibault Polge
2019-08-17 18:34 ` Amin Bandali
2019-08-18 19:23 ` Alex Branham
2019-08-22 16:54 ` Thibault Polge
2019-08-24 16:45 ` Noam Postavsky
2019-08-27 14:31 ` Amin Bandali
2019-09-04 14:05 ` Alex Branham
2019-09-05 23:57 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blvymh3a.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=36843@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=thibault@thb.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).