From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Leonard Lausen Newsgroups: gmane.emacs.bugs Subject: bug#37331: 27.0.50; segfault when starting from pdump and using dbus Date: Fri, 13 Sep 2019 09:25:46 +0000 Message-ID: <87blvo8s4l.fsf@lausen.nl> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="260943"; mail-complaints-to="usenet@blaine.gmane.org" Cc: , 37331-done@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 13 11:27:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8hrq-0015lI-Sc for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 11:27:50 +0200 Original-Received: from localhost ([::1]:41732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8hrp-00072L-Ky for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 05:27:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54156) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8hq7-0004cF-GS for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 05:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8hq6-0007cD-0y for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 05:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8hq5-0007c5-U7 for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 05:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i8hq5-0006Nh-NS for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 05:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leonard Lausen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Sep 2019 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37331 X-GNU-PR-Package: emacs Original-Received: via spool by 37331-done@debbugs.gnu.org id=D37331.156836675624517 (code D ref 37331); Fri, 13 Sep 2019 09:26:01 +0000 Original-Received: (at 37331-done) by debbugs.gnu.org; 13 Sep 2019 09:25:56 +0000 Original-Received: from localhost ([127.0.0.1]:44373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8hpz-0006NN-SA for submit@debbugs.gnu.org; Fri, 13 Sep 2019 05:25:56 -0400 Original-Received: from devico.uberspace.de ([185.26.156.185]:50148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8hpx-0006NB-LR for 37331-done@debbugs.gnu.org; Fri, 13 Sep 2019 05:25:54 -0400 Original-Received: (qmail 19892 invoked from network); 13 Sep 2019 09:25:50 -0000 Original-Received: from unknown (HELO localhost) (84.58.206.209) by devico.uberspace.de with SMTP; 13 Sep 2019 09:25:50 -0000 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166387 Archived-At: Thank you for looking into the problem! Your fix indeed prevents the crash. Unfortunately there seems to be an issue with dbus sessions. For exmaple, notmuch-search from notmuch.el or fcitx--prefix-keys-polling-function error out with (dbus-error "No connection to bus" :session) when loading a pdumped session. Would you like me to prepare a minimal reproducible example? Should I open a new bug? Above report is based on the emacs config at https://github.com/leezu/dotfiles/tree/master/emacs which uses spacemacs. Best regards Leonard Paul Eggert writes: > Thanks for reporting the problem. I reproduced it and installed the attached > patch, which should fix it. > From cc4da5b17e9e9aa522a0bd77dc341cd14ec9ea43 Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Wed, 11 Sep 2019 10:19:07 -0700 > Subject: [PATCH] Reset dbus registered buses on dump load > > Problem reported by Leonard Lausen (Bug#37331). > * src/dbusbind.c: Include pdumper.h. > (syms_of_dbusbind_for_pdumper): > New function, to reset the registered buses. > (syms_of_dbusbind): Use it, fixing a TODO. > --- > src/dbusbind.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/src/dbusbind.c b/src/dbusbind.c > index 7f4c8717f4..de67dc94f9 100644 > --- a/src/dbusbind.c > +++ b/src/dbusbind.c > @@ -26,6 +26,7 @@ > #include "lisp.h" > #include "termhooks.h" > #include "keyboard.h" > +#include "pdumper.h" > #include "process.h" > > #ifndef DBUS_NUM_MESSAGE_TYPES > @@ -1681,6 +1682,12 @@ init_dbusbind (void) > xputenv ("DBUS_FATAL_WARNINGS=0"); > } > > +static void > +syms_of_dbusbind_for_pdumper (void) > +{ > + xd_registered_buses = Qnil; > +} > + > void > syms_of_dbusbind (void) > { > @@ -1829,13 +1836,10 @@ syms_of_dbusbind (void) > #endif > > /* Initialize internal objects. */ > - xd_registered_buses = Qnil; > + pdumper_do_now_and_after_load (syms_of_dbusbind_for_pdumper); > staticpro (&xd_registered_buses); > > - // TODO: reset buses on dump load > - > Fprovide (intern_c_string ("dbusbind"), Qnil); > - > } > > #endif /* HAVE_DBUS */ > -- > 2.17.1