From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36670: 27.0.50; Wishlist: describe-face should use the new help-buffer infrastructure Date: Sat, 21 Sep 2019 09:44:51 +0200 Message-ID: <87blve2ivg.fsf@gnus.org> References: <87d0ibcm0z.fsf@mouse.gnus.org> <87ef0a60uu.fsf@gnus.org> <831rwarw0g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48166"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36670@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 21 09:46:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBa5u-000CPa-Fr for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 09:46:14 +0200 Original-Received: from localhost ([::1]:39980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBa5t-0003A2-DM for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Sep 2019 03:46:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33038) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBa5l-00033i-IV for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 03:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBa5j-0007iA-Na for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 03:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBa5i-0007hZ-Ck for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 03:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBa5i-0004ir-87 for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2019 03:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2019 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36670 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 36670-submit@debbugs.gnu.org id=B36670.156905190118047 (code B ref 36670); Sat, 21 Sep 2019 07:46:02 +0000 Original-Received: (at 36670) by debbugs.gnu.org; 21 Sep 2019 07:45:01 +0000 Original-Received: from localhost ([127.0.0.1]:58999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBa4i-0004gp-V6 for submit@debbugs.gnu.org; Sat, 21 Sep 2019 03:45:01 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:48224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBa4g-0004gf-Ez for 36670@debbugs.gnu.org; Sat, 21 Sep 2019 03:44:58 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBa4Z-0007cX-VF; Sat, 21 Sep 2019 09:44:57 +0200 In-Reply-To: <831rwarw0g.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Sep 2019 09:41:51 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166840 Archived-At: Eli Zaretskii writes: > What does this mean in practice? I see nothing about this in NEWS or > in the manuals, which makes me wonder how is this "more flexible". I > guess there were some discussions, but neither the log message nor the > bug discussion mentions any other sources of information. Could you > please point to those discussions, or fill the void by explaining what > additional flexibility do we gain? This is for future forensics, if > for nothing else. I don't think this was discussed much at all -- it relates to the rewrite Stefan did in April, and he mentioned (in a comment to a fix to `describe-face') that that function should be rewritten in a similar way. commit 896e5802160c2797e689a7565599ebb1bd171295 Author: Stefan Monnier Date: Fri Apr 12 12:37:00 2019 -0400 * lisp/help-fns.el (help-fns-describe-variable-functions): New hook (help-fns--compiler-macro, help-fns--parent-mode, help-fns--obsolete) (help-fns--interactive-only): Indent output by 2 spaces. (help-fns--side-effects): New function extracted from describe-function-1. (help-fns-describe-function-functions): Use it. (help-fns--first-release, help-fns--mention-first-release): New functions. (help-fns-function-description-header): Keymaps and macros can't be interactive. (help-fns--ensure-empty-line): New function. (describe-function-1): Use it. (help-fns--var-safe-local, help-fns--var-risky) (help-fns--var-ignored-local, help-fns--var-file-local) (help-fns--var-watchpoints, help-fns--var-obsolete) (help-fns--var-alias, help-fns--var-bufferlocal): New functions, extacted from describe-variable. (describe-variable): Run help-fns-describe-variable-functions instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no