From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#37515: 27.0.50; button.el doesn't support help-echo function Date: Tue, 01 Oct 2019 13:32:36 +0100 Message-ID: <87blv03au3.fsf@tcd.ie> References: <87zhirdv75.fsf@gnus.org> <87ftki1xby.fsf@gnus.jao.io> <87sgodftxd.fsf@tcd.ie> <878sq48xa5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="58467"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Katsumi Yamaoka , "Jose A. Ortega Ruiz" , 37515@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 14:33:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFHLB-000F5T-BX for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 14:33:17 +0200 Original-Received: from localhost ([::1]:41430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFHL9-00053e-T4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 08:33:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45135) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFHL0-0004zj-Na for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFHKz-0006Qu-Oi for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:33:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFHKw-0006LO-Ch for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFHKw-00043J-7y for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 08:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 12:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37515 X-GNU-PR-Package: emacs Original-Received: via spool by 37515-submit@debbugs.gnu.org id=B37515.156993316715553 (code B ref 37515); Tue, 01 Oct 2019 12:33:02 +0000 Original-Received: (at 37515) by debbugs.gnu.org; 1 Oct 2019 12:32:47 +0000 Original-Received: from localhost ([127.0.0.1]:32791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFHKh-00042m-Bj for submit@debbugs.gnu.org; Tue, 01 Oct 2019 08:32:47 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:32830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFHKe-00042a-LC for 37515@debbugs.gnu.org; Tue, 01 Oct 2019 08:32:45 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id b9so15317394wrs.0 for <37515@debbugs.gnu.org>; Tue, 01 Oct 2019 05:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0HwvyzQiIs2ODf34VyIRLC7OYR90+KwA9D5wvgnHCek=; b=GoKmNVNjcq54hTgiZ5UfKuNqIJW2dLn4/jSONFiwcxpo3L8AYjQlGgbzNxrEXBeA4U yVh8oc1xyL6/sVWzhFuwUdMEJ10Pa+T0KH6VSP0TaxcckyNimEhj0JscwIPmA425qFvM LWTVI27tu19zco5w6GNaaao1LQsPeGr8iWtc0Usf3DzwC62zSI7NBsfA9/jDElrJh+YP +zmplDJPkr+mhGIsQwWVEQ6Wkj0kTj9oRjwQZbrTSNvreRdtkeyQtiBXtixxTFj25wnG oDGqLUPbWfzJ+TVRP1ovbg2+0Ujgrd/lNk0rYGCS2AQPfVCm7kZLWjbV67cAH3T+oB7u aLog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0HwvyzQiIs2ODf34VyIRLC7OYR90+KwA9D5wvgnHCek=; b=NrUwvH9h2lvnA8Akqfs9Oe5NtPJw0c9hD4RO02Tf0GgHWN93tt078ObB9E6IZ0M7bF bJ8BL+xHKIc4UkPctXL/cUQ8U6TysA9ecVm+2at/DgO7gzGdtyWPFlqa6jAG0A/+bKNG ZTt4j07l/2nIQ0wAiC0OHwKffAd54WWMxxTEOuvICpWhgxa/3IW2Df0C7jwlwpVZ9Zoo 2UXEz1qCXIHMiBpUGoA+HC9sykea8oDyrhQMYTVmWmCF1E3iLwjhITfVuKzZ5poxfCyx hYFRV+90weMcxdcrbn8yyANRtxPhCm1nm+zUy7/2o0/SilYkb9N4YKoyGXJM7Y4OFFuf gSuA== X-Gm-Message-State: APjAAAUCM1TtDRpAB+TIWF+lsw5pR3NfiSa481cjuZPoP0Of6qhDBmCD hu6vUNPu8zrzbS4Ym3h5+DHqlg== X-Google-Smtp-Source: APXvYqzC1MRpX90wirBVeAkH2iwfSUOsMh+c8uERzijpLKcAJSzp8xuEBCn8qiDbaDZAWFpDvWYCMA== X-Received: by 2002:adf:cc87:: with SMTP id p7mr17633582wrj.43.1569933159024; Tue, 01 Oct 2019 05:32:39 -0700 (PDT) Original-Received: from localhost ([134.226.214.212]) by smtp.gmail.com with ESMTPSA id f10sm2362960wml.4.2019.10.01.05.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 05:32:38 -0700 (PDT) In-Reply-To: <878sq48xa5.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 01 Oct 2019 14:28:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167986 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >> Some further changes are needed to fully support the help-echo property. >> Firstly, help-echo functions expect an overlay as their second argument >> when the object that had the property is an overlay (button). Secondly, >> help-echo values can be forms in addition to strings and functions. >> Lastly, (info "(elisp) Button Properties") needs updating to reflect the >> supported values of the help-echo button property. >> >> The following patch should do all this. I will push it in the next few >> days if there are no objections. WDYT? > > Looks good to me. Thanks! (The updated patch I just sent merely extends the tests.) -- Basil