From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 24 Oct 2019 19:04:31 +0200 Message-ID: <87blu6krc0.fsf@gmail.com> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <6f01b03d-7be3-71cc-ff97-c1a4f7b3c213@yandex.ru> <83tv879vy0.fsf@gnu.org> <6bc27f9f-e701-afb8-c6f1-408f471187c7@yandex.ru> <83imon9tg3.fsf@gnu.org> <5db11c91-a216-40f6-f4c2-7b10c73532cc@yandex.ru> <83h8424ojp.fsf@gnu.org> <9fbdd8e8-4f6a-1aba-6509-d2699c82373b@yandex.ru> <83k18vzd1j.fsf@gnu.org> <3919a409-1a2b-8da6-a1d0-f9f6def09dfe@yandex.ru> <831rv3z6cn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120453"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 37774@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 24 19:42:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNh8P-000VCn-7W for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Oct 2019 19:42:53 +0200 Original-Received: from localhost ([::1]:49172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNh8N-00072M-Hm for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Oct 2019 13:42:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36419) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNgXn-0007Ju-QZ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 13:05:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNgXm-0006Y8-HL for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 13:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNgXm-0006Y2-ED for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 13:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNgXm-0006fo-8P for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2019 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157193668625625 (code B ref 37774); Thu, 24 Oct 2019 17:05:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 24 Oct 2019 17:04:46 +0000 Original-Received: from localhost ([127.0.0.1]:36872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNgXV-0006fF-VW for submit@debbugs.gnu.org; Thu, 24 Oct 2019 13:04:46 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:36107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNgXU-0006f0-3o for 37774@debbugs.gnu.org; Thu, 24 Oct 2019 13:04:44 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id w18so26384045wrt.3 for <37774@debbugs.gnu.org>; Thu, 24 Oct 2019 10:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=L61oYBSlR7vrLLKmEM0Eh7Nww7NRXd0S6tyaTjvOdN0=; b=cQPElOqo8+l8AIOUxl78TWSkR59mlJqlnUEWJannyYHj0Yt7Yx5T6QWH70a868s2vV sJ9RoI9FfdQMFV12fvS+UXbQtoiXb1YFohTSapOJ7seoPsQtE2nu2m1FANqlK3vRtuEd QqCxCcXgRLJLO5gaW1y72heMO42mCmlt2Vr+seEFibJsIKXfEgce0n8JSlGWB2BMfdyn J4Bn8r/+E0DRWYvFXViJ6WHh0cEQC+Q14oQacSNATkVr7b4nL3svvpgiEhrf4Gxjsncd n0nxOlhTWNu+ssN5Mc1RiVDu66QMQY8u6mRfSHjYfdxCxx1bmNJR1loxjFq74aYCZiqf EXMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=L61oYBSlR7vrLLKmEM0Eh7Nww7NRXd0S6tyaTjvOdN0=; b=sIVxDXBdrcyMUf9rdx1eoXyh3tlySsJIScsiujbuC863LD876B8vZWTncvcYAqPdbT HqsbHaKGAWik/iUtBDcVjQ8wYwKaInXp7k/+gFn7Li/SkIVt+uYgnV2jmRFrp9XgPnIK e59fJRnxAti42rMLyMCLbRupE4K2M2xhTAXTZCIcVoyTtWqqaDPYUx2nr6VcPoeH/dZA GUj7znJarpFqUzC+euktGfZhIvsRuceKJ0KULlwh83noy+MF7VTL8vetRJioB5mF2cEt 7px/FuDlIzAfaY6TQe8XFZHbgT5Hj488raNvEX6z3vxV3W1zazRAYfUY+9dgnIISdGhT DHYg== X-Gm-Message-State: APjAAAXFBHzcNu51Z9WbkcXTc9t2065D6GOPfxTLGllaxivXspg/HYu7 dyS1hZk0xkG6tUsOOyDgNGeQY1Qb X-Google-Smtp-Source: APXvYqyFFEDv1IV6KVwxNRybpMaGiAi/ivkid/fLiRLhLPS9zUKilmkRJ+5OjDL3f1cpTWF3i029QA== X-Received: by 2002:adf:ea50:: with SMTP id j16mr4622657wrn.295.1571936677963; Thu, 24 Oct 2019 10:04:37 -0700 (PDT) Original-Received: from little-buster ([92.184.101.110]) by smtp.gmail.com with ESMTPSA id s21sm31144054wrb.31.2019.10.24.10.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 10:04:36 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Wed, 23 Oct 2019 23:28:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170140 Archived-At: --=-=-= Content-Type: text/plain Dmitry Gutov writes: > Yeah, so: what's the plan for Magit? > > Will the new version of it have to > > (if > (defface ...) > (defface ...) > > ? > We should define and document a "migration path", e.g. say what a > package author should do if they have a face which needs to be > extended, preferably without breaking compatibility with Emacs 26. Earlier in the thread[1] I suggested this method to avoid the duplicate defface issue: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=demo.patch --- magit-diff.el.bkp 2019-10-23 17:02:13.340410735 +0200 +++ magit-diff.el 2019-10-24 17:54:58.769446997 +0200 @@ -509,12 +509,14 @@ :group 'magit-faces) (defface magit-diff-hunk-heading - '((((class color) (background light)) + `((((class color) (background light)) :background "grey80" - :foreground "grey30") + :foreground "grey30" + ,@(when (>= emacs-major-version 27) '(:extend t))) (((class color) (background dark)) :background "grey25" - :foreground "grey70")) + :foreground "grey70" + ,@(when (>= emacs-major-version 27) '(:extend t)))) "Face for diff hunk headings." :group 'magit-faces) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Would this be an acceptable migration path? Magit requires Emacs=E2=89=A52= 5.1 if I am not mistaken; I don't know how portable this solution would be. [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37774#212 AFAICT no-one outright rejected this idea; I apologize if I missed someone pointing out shortcomings. --=-=-=--