From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#35564: [PATCH v5] Tweak dired warning about "wildcard" characters Date: Mon, 04 Nov 2019 07:36:53 +0100 Message-ID: <87bltscflm.fsf@gmail.com> References: <87zho2cd4f.fsf@gmail.com> <87wohvf22u.fsf@gmail.com> <87h88cvpkj.fsf_-_@gmail.com> <87imsinbmr.fsf_-_@gmail.com> <87o8yoign9.fsf_-_@gmail.com> <87v9sgrf29.fsf@gmail.com> <87d0eoseax.fsf@mail.linkov.net> <87mudstrir.fsf@gmail.com> <87a79l7vk4.fsf@mail.linkov.net> <8736f9ao8n.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="213317"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , 35564@debbugs.gnu.org, Noam Postavsky , Stefan Monnier To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 04 07:38:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRW0B-000tN9-M4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Nov 2019 07:38:11 +0100 Original-Received: from localhost ([::1]:58048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRW09-0000yb-UP for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Nov 2019 01:38:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47606) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRW03-0000yV-BR for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2019 01:38:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRW02-0007aD-7u for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2019 01:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55176) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRW02-0007a7-2i for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2019 01:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iRW01-0004Ow-Ux for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2019 01:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Nov 2019 06:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35564-submit@debbugs.gnu.org id=B35564.157284942516837 (code B ref 35564); Mon, 04 Nov 2019 06:38:01 +0000 Original-Received: (at 35564) by debbugs.gnu.org; 4 Nov 2019 06:37:05 +0000 Original-Received: from localhost ([127.0.0.1]:35764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRVz7-0004NV-2h for submit@debbugs.gnu.org; Mon, 04 Nov 2019 01:37:05 -0500 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:36270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRVz5-0004Mz-1H for 35564@debbugs.gnu.org; Mon, 04 Nov 2019 01:37:03 -0500 Original-Received: by mail-wr1-f49.google.com with SMTP id w18so15636968wrt.3 for <35564@debbugs.gnu.org>; Sun, 03 Nov 2019 22:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=6yhoxC/3I1rZvLDSybr7TTA4S+YmyK3jcydSN3+zy54=; b=Gh/00jbXNObYRd9OXeZXkxrewjGemvwCg53WLAN1KFlrmqQSaWjEy1drzUIYUBN/Wz tr2caeo/WG21LZsV5iTV4SHSmOxYaSOeBhjguKOaUZRhOAJOoa4T0+2D0tDTPp4o1iHd BJPzdQlEBrCpYLjzFO6AR/OZsGue+3LmFCufd8y0vL4aAWWkta/lyxF77ue9Hjqp9kxe m4pwvOuixa84AukhjzxXk+GUYbocUN6c9lls04brDnVYnIVZwm2nf3vmQsbB0ZTLPiH6 olAPInd4pEblGAFAc/5UAk44Cfvemn/ZCul7qfXVnpH/wc7kGiUyujQpcx41wIUTUDzc ZdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=6yhoxC/3I1rZvLDSybr7TTA4S+YmyK3jcydSN3+zy54=; b=eOxVTSd38vQ502Aa0Zx5MOsldl4f2rcA1Qb/fy0ZiONbomSwIwJkRPh3bk8VBwCcEi GsXMk51aFp9lRc1jkDMsldvxwyJtAMGDvGbI4Lmyu/aocj7Q0zHXU2h3JdbywKkD1Tut Cby5DK+B9whTByGxa5dyGHkN+8GXLP6EJ/p/2UIaQtk5ULqGh4upOvUHfVH769NZg9Hx VpQYe43aqgnP0KVVHKvJu1RJvdCvU0BT4JU2G8SPjm5Bacq9JfZQG2pt+Ms7+7xVH74c 5B48Oph1ebKXcixC4OpBZD1RTjc4COGv3aHb+RDuQzbLbPwy6M/XJDJX6iysk0qA70CG 87SA== X-Gm-Message-State: APjAAAVNK5hlAZx5kyYWaJMs7Nzk7MNhRgJhXONvhqaP/G+OP0iWBymU 3oaT3ivKfZafQ16S+pawsCA= X-Google-Smtp-Source: APXvYqyo8OmDqkPUj9M2R1FaqGOKerj7LSlypqztt7Pd+XegK72HWzeAG3z636q8H9lbWCCBcDJReQ== X-Received: by 2002:a5d:414a:: with SMTP id c10mr4508331wrq.100.1572849417113; Sun, 03 Nov 2019 22:36:57 -0800 (PST) Original-Received: from little-buster ([109.190.253.11]) by smtp.gmail.com with ESMTPSA id z15sm15463251wrr.19.2019.11.03.22.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Nov 2019 22:36:55 -0800 (PST) In-Reply-To: <8736f9ao8n.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 30 Oct 2019 23:59:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170914 Archived-At: Juri Linkov writes: >> '?' would be more preferable since this is the standard way to ask >> for additional information in Dired, for example, on error it shows: >> >> Dired error--type ? for details >> >> where '?' shows the details. dired-do-shell-command should do the same >> in its prompt. read-multiple-choice could be changed to not add >> its own help option when a '?' is provided in its 'choices' arg. > > I meant using the same logic as in 'read-answer': > > (if (assoc "help" answers) > answers > (append answers '(("help" ?? "show this help message")))) > > i.e. if '?' is provided in the function argument then use it, > otherwise use the default value. I'd like to keep read-multiple-choice's built-in help action available though, I find it quite ergonomic. Plus, the fact that it is bound to ? and C-h makes it consistent with help-for-help, another command whose purpose is to describe prompt bindings in more details. Here are the ways forward I can see: 1. keep 'd' for "details" (a la nsm.el), 2. use 'h' for "help": more intuitive for "what the ftok is going on" reactions, though perhaps confusing when shown alongside '?', 3. teach read-multiple-choice to let go of '?', and=E2=80=A6 3.1. that's it; give up on the bindings-explaining help buffer, 3.2. move the code generating this buffer to an external function, which callers could re-use to fill in their own help buffer, 4. add a third, optional argument to read-multiple-choice (e.g. help-text) that would be added to the help buffer (e.g. squeezed between the prompt and the bindings). Ranked according to my preference: 1. (keeping "help" mnemonics (?, C-h) for "what can I do" actions, and "details/description/debug" mnemonics for "give more context" actions) 4. (reduces the number of actions for this specific prompt) 3.2. (same, only more involved) 3.1. (sad to give up on the bindings description) 2. (see rationale for 1; plus 'h' and '?' doing different things might be confusing) Tell me if there are other solutions I missed, or if you find any of these satisfying! Thank you for your time, and for the review.