bug#35079: 26.1; Font rendering - problem with bdf fonts

[Lars Ingebrigtsen <larsi@gnus.org>]

handa.kenichi@aist.go.jp (K.Handa) writes:

> Or, please try to apply this patch to src/xftfont.c, and rebuild emacs.
>
> diff --git a/src/xftfont.c b/src/xftfont.c
> index 8a4516f7f9..bb15a83685 100644
> --- a/src/xftfont.c
> +++ b/src/xftfont.c
> @@ -349,7 +349,7 @@ xftfont_open (struct frame *f, Lisp_Object entity, int pixel_size)
>
>    if (spacing != FC_PROPORTIONAL
>  #ifdef FC_DUAL
> -      && spacing != FC_DUAL
> +      && spacing != FC_DUAL && spacing != FC_CHARCELL
>  #endif	/* FC_DUAL */
>        )
>      {
>
> I don't know the exact meaning of FC_CHARCELL.  I could't find it on the
> Internet.  Does anyone know what it means and why fontconfig uses it for
> the gnu unifont?

It seems like many people are wondering what it means, but

https://gitlab.freedesktop.org/fontconfig/fontconfig/issues/176#note_221223

says

"FC_DUAL should be an alias to FC_CHARCELL and use FC_CHARCELL in this
case too perhaps"

So it seems like the solution here is possibly correct (although perhaps
there should be an #ifdef FC_CHARCELL there, too).

It seems like it shouldn't hurt, at least.

Opinions?  If nobody objects, then perhaps the following could be
installed:

diff --git a/src/xftfont.c b/src/xftfont.c
index e003580817..fa06d96736 100644
--- a/src/xftfont.c
+++ b/src/xftfont.c
@@ -211,6 +211,9 @@ xftfont_open (struct frame *f, Lisp_Object entity, int pixel_size)
 #ifdef FC_DUAL
       && spacing != FC_DUAL
 #endif	/* FC_DUAL */
+#ifdef FC_CHARCELL
+      && spacing != FC_CHARCELL
+#endif	/* FC_CHARCELL */
       )
     {
       font->min_width = font->max_width = font->average_width


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no