From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#29842: 27.0; `dired-change-marks': args should not be optional Date: Sun, 19 Jan 2020 16:02:45 +0100 Message-ID: <87blqzv696.fsf@marxist.se> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 29842@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 19 16:03:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itC6b-000UxS-9h for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jan 2020 16:03:13 +0100 Original-Received: from localhost ([::1]:50810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itC6Z-0007lH-Uk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jan 2020 10:03:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43760) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itC6R-0007l3-4m for bug-gnu-emacs@gnu.org; Sun, 19 Jan 2020 10:03:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itC6Q-0007D9-6t for bug-gnu-emacs@gnu.org; Sun, 19 Jan 2020 10:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itC6P-0007Cg-Sm for bug-gnu-emacs@gnu.org; Sun, 19 Jan 2020 10:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itC6P-000494-Q7 for bug-gnu-emacs@gnu.org; Sun, 19 Jan 2020 10:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jan 2020 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29842 X-GNU-PR-Package: emacs Original-Received: via spool by 29842-submit@debbugs.gnu.org id=B29842.157944617615915 (code B ref 29842); Sun, 19 Jan 2020 15:03:01 +0000 Original-Received: (at 29842) by debbugs.gnu.org; 19 Jan 2020 15:02:56 +0000 Original-Received: from localhost ([127.0.0.1]:43721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itC6J-00048c-Nc for submit@debbugs.gnu.org; Sun, 19 Jan 2020 10:02:55 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:50884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itC6H-00048L-Ih; Sun, 19 Jan 2020 10:02:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bx8G0eOdcUbhrtDu/tVueRQ8Gmp/n5e8O3CK/8CiOsM=; b=gvZojAv2mfxFfi8lTjC2jVq+rq u7WeHca1C1mzBl4Xo+Rgp2+u6ObKf4zyoHTWoy+fmc0q4w6CHwJ+lwditlWOkEVxn6/P2cE3/j+ox szg/C/EHLclcyLI58XYwqCB6KSFBDW35306WRzTl5oQEEieMyOYWgAeDl/POZbDZT28MQRLIfJk/D KMHJJjL72bwadtEl/grpJv02w7EJvdEwNMhdPLVeB5KAiS3m2zI4QW/Xs1UXZjfAHAn78A6BUIFiy O/ZRrWWEvM7ZcIu6OpCtQ3HQGsZuJz5gkMqja/EoIf6J3BeDg+Vv45P7QwTUHsjQM6zkjKgft2W8G +V5zKABw==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:38616 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itC6B-001v28-D9; Sun, 19 Jan 2020 10:02:47 -0500 In-Reply-To: (Drew Adams's message of "Sun, 24 Dec 2017 10:30:54 -0800 (PST)") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174866 Archived-At: close 29842 28.1 thanks Drew Adams writes: > Furthermore, the code should perhaps not just call > `ding' if you hit RET. Instead of this: > > (if (or (eq old ?\r) (eq new ?\r)) > (ding) > ...) > > it should perhaps do something like this: > > (unless (char-displayable-p old) > (error "Not a displayable character: `%c'" old)) > (unless (char-displayable-p new) > (error "Not a displayable character: `%c'" new)) > > The current code predates the existence of > `char-displayable-p'. > > (Yes, that's a different bug, but perhaps it can be > taken care of in the context of this report. If not, > don't worry about it.) Fixed on master in commit e5e31aab9b. Best regards, Stefan Kangas