From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pierre Neidhardt Newsgroups: gmane.emacs.bugs Subject: bug#39596: 26.3; Export INSIDE_EMACS with Eshell Date: Wed, 19 Feb 2020 08:40:19 +0100 Message-ID: <87blpvc9ek.fsf@ambrevar.xyz> References: <87a75lvds8.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="114018"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39596@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 19 08:41:36 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j4JzD-000TWF-Cc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 08:41:35 +0100 Original-Received: from localhost ([::1]:46784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4JzC-0005QK-FY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Feb 2020 02:41:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50154) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4Jyh-0005QE-Qe for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 02:41:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4Jyg-0007fp-Gv for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 02:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4Jyg-0007ff-D8 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 02:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j4Jyg-0003P3-B0 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2020 02:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2020 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39596 X-GNU-PR-Package: emacs Original-Received: via spool by 39596-submit@debbugs.gnu.org id=B39596.158209802513026 (code B ref 39596); Wed, 19 Feb 2020 07:41:02 +0000 Original-Received: (at 39596) by debbugs.gnu.org; 19 Feb 2020 07:40:25 +0000 Original-Received: from localhost ([127.0.0.1]:41590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4Jy4-0003O1-Vq for submit@debbugs.gnu.org; Wed, 19 Feb 2020 02:40:25 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:59987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j4Jy2-0003Ns-G8 for 39596@debbugs.gnu.org; Wed, 19 Feb 2020 02:40:23 -0500 Original-Received: from bababa (lfbn-idf2-1-1315-147.w92-169.abo.wanadoo.fr [92.169.129.147]) (Authenticated sender: mail@ambrevar.xyz) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 7D71E240007; Wed, 19 Feb 2020 07:40:20 +0000 (UTC) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176237 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Thanks for looking at this, Federico! Your patch looks good to me, just one comment below: > --- a/lisp/eshell/em-dirs.el > +++ b/lisp/eshell/em-dirs.el > @@ -191,6 +191,9 @@ eshell-dirs-initialize > (unless (ring-empty-p eshell-last-dir-ring) > (expand-file-name > (ring-ref eshell-last-dir-ring 0)))) > + t) > + ("INSIDE_EMACS" ,(lambda (_indices) > + (format "%s,eshell" emacs-version)) > t)))) Why did you unquote the lambda here? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl5M5mMACgkQm9z0l6S7 zH/kvQgAoK4jKWp9ff53/cuveh8ykqZHabF1INx4y2mbnU4Aren+VGczZ4n1XdOi Bg93f0+eFehrpGNMIG7fbWZrXlYm5HNAVhm+TewhPj5IkhoKynwuXNEi3rax61E2 8yNvkQwxA37pM6FZxjJG+UtBf3Qmc3MjN4N7GyGZTDKatfDO1G2Ef4scImoj/HPq bDVptQwMe9+Y51RewhPFS2GmBZonrjW1vaWpZkPr01BptpFhr6AJo13eJ2FaETLB l3FWrJQ5k39Cqml67tac6Lj1fHBx6UOrwDJoq2ulitsYxAB60MRV9aowddxpU2jS hNXLB/TYeJxuWHR++SE9ospC048ezQ== =3ycH -----END PGP SIGNATURE----- --=-=-=--