From: Tomas Nordin <tomasn@posteo.net>
To: Arun Isaac <arunisaac@systemreboot.net>, 40202@debbugs.gnu.org
Subject: bug#40202: directory-files-recursively docstring unclear about include-directories
Date: Wed, 25 Mar 2020 18:20:06 +0100 [thread overview]
Message-ID: <87blokl5bt.fsf@fliptop.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <cu7mu86vkjc.fsf@systemreboot.net>
Arun Isaac <arunisaac@systemreboot.net> writes:
> Hi,
>
> The docstring of directory-file-recursively in lisp/files.el is unclear
> about the include-directories optional argument. It currently reads
>
> "Optional argument INCLUDE-DIRECTORIES non-nil means also include
> in the output directories whose names match REGEXP."
>
> Perhaps this could be rewritten as
>
> "If optional argument INCLUDE-DIRECTORIES is non-nil, the returned list
> also includes directories whose names match REGEXP."
Or a more prompting style
"If INCLUDE-DIRECTORIES is non-nil, also include directories whose names
matches REGEXP in the returned list."
I think it is not necessary to repeat that the argument is optional, but
maybe that is standard.
?
Best regards
--
Tomas
next prev parent reply other threads:[~2020-03-25 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 21:16 bug#40202: directory-files-recursively docstring unclear about include-directories Arun Isaac
2020-03-24 3:25 ` Eli Zaretskii
2020-03-24 8:22 ` Arun Isaac
2020-03-24 21:23 ` Lars Ingebrigtsen
2020-03-25 17:20 ` Tomas Nordin [this message]
2020-03-25 19:38 ` Arun Isaac
2020-03-25 19:57 ` Eli Zaretskii
2020-03-25 21:36 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blokl5bt.fsf@fliptop.i-did-not-set--mail-host-address--so-tickle-me \
--to=tomasn@posteo.net \
--cc=40202@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).