From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Date: Thu, 11 Jun 2020 00:52:28 +0300 Organization: LINKOV.NET Message-ID: <87bllqoag3.fsf@mail.linkov.net> References: <87h7vkihci.fsf@tcd.ie> <833674710g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="128120"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: "Basil L. Contovounesios" , "41766@debbugs.gnu.org" <41766@debbugs.gnu.org>, "dgutov@yandex.ru" To: Simon Lang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 10 23:57:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj8jE-000XFD-DG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 23:57:48 +0200 Original-Received: from localhost ([::1]:50712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj8jD-0001Ju-Fw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 17:57:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj8iU-0000XB-W3 for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 17:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52206) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj8iU-0005qc-Mp for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 17:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj8iU-0005Bp-MD for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 17:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2020 21:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41766 X-GNU-PR-Package: emacs Original-Received: via spool by 41766-submit@debbugs.gnu.org id=B41766.159182619419899 (code B ref 41766); Wed, 10 Jun 2020 21:57:02 +0000 Original-Received: (at 41766) by debbugs.gnu.org; 10 Jun 2020 21:56:34 +0000 Original-Received: from localhost ([127.0.0.1]:35516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj8i2-0005An-GZ for submit@debbugs.gnu.org; Wed, 10 Jun 2020 17:56:34 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj8i0-0005AL-O4 for 41766@debbugs.gnu.org; Wed, 10 Jun 2020 17:56:33 -0400 X-Originating-IP: 91.129.108.6 Original-Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 8BE22C0003; Wed, 10 Jun 2020 21:56:24 +0000 (UTC) In-Reply-To: (Simon Lang's message of "Wed, 10 Jun 2020 21:11:09 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181835 Archived-At: > I now something to the manual, NEWS and changed the doc string + commit msg > as advised. I decided on defcustom in the end because this way it is easy > for the user to figure out what goes wrong in case he/she modifies > grep-command and highlighting is missing. Hope that is fine. In the long run what should be customizable is not escape sequences, but a choice of the grep program with a list of such options: "GNU grep" "ripgrep" ... i.e. the same customization as for the selection of the web browser in browse-url.el.