From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35186: 26.1; confusing error message and location on eager dotted pair evaluation Date: Thu, 20 Aug 2020 18:28:11 +0200 Message-ID: <87blj5qo2s.fsf@gnus.org> References: <87a7h1qzft.fsf@debian-x1g4.i-did-not-set--mail-host-address--so-tickle-me> <8736jftclo.fsf@mouse.gnus.org> <87a7dndq2y.fsf@web.de> <87h7sxs5fb.fsf@gnus.org> <87wo1tuwxo.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ernesto Alfonso , 35186@debbugs.gnu.org, Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 18:29:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8nRW-000AW9-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 18:29:34 +0200 Original-Received: from localhost ([::1]:46016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8nRV-0005fi-MV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 12:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8nR0-0004vO-Mk for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 12:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8nR0-0001bF-CR for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 12:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8nR0-0006Nv-AG for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 12:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 16:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35186 X-GNU-PR-Package: emacs Original-Received: via spool by 35186-submit@debbugs.gnu.org id=B35186.159794090524452 (code B ref 35186); Thu, 20 Aug 2020 16:29:02 +0000 Original-Received: (at 35186) by debbugs.gnu.org; 20 Aug 2020 16:28:25 +0000 Original-Received: from localhost ([127.0.0.1]:43674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8nQP-0006MJ-04 for submit@debbugs.gnu.org; Thu, 20 Aug 2020 12:28:25 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8nQM-0006M6-Tq for 35186@debbugs.gnu.org; Thu, 20 Aug 2020 12:28:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xXK0PC5fNLu7PPMqzNwwDhfkTkWtyMTthxPsJuz6lrs=; b=erDKeNsSVEHYvWRgf00Vh3nIEl 73qLzxE7lhD5viHPuj9VaOfu5Ta4m3V4NNkQ3BOmgwWkf14UkYSiS8XuYTCfi0AyiJeQWhL9fG7g+ 0z3l8ARLCCNF5LoHT5xKuEHpjG6DbD9pfOkXdB9Ag2wCW6KwWPoLjs3qkcopnwFD5Pds=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8nQD-0006nR-0y; Thu, 20 Aug 2020 18:28:15 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEX69O6km6YlCRdl RVF5dofZnG6wYULNys9cExyVJx/Qtab788353qnmqUn///8hh7pzAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+QIFBAbBvJ5teIAAAGgSURBVDjLpZE/a8JAGMYjHTp0UVtI1950awmIayG0X6CxIG4lVxQE hUJmzfKmH0CMeztIB/dz6OLkuTq0yXfpe5c/d9pCxT7DJTy/e9573zvLOkZ1R8pF3Xj37q3zVAJC CA2dR8Z8r+UwNlPumQQ0hLDhKTGfvegEEBKyDHgtE1AARwIhVpjp6VJQAkkeygTFphrM7wix5MJb JVYeqUub+W2x5iiRg4Wco4F1OoJnWn0Vpc7RnmfbVWRdgNf2/F0U+zlfauB5baET/KMAb37WaQ6X iW4XohjF+mmC/kYDvEMgNIpZmq75Jv00AIxzkIjUBHhXADFDIKVBGDabCOKJRNt+z3woPEN2gIDt AHk4qM62xQsWZ2BIgkm3i2Ch5wCgaKtx4pnFF9ntgtpcglFR6rLwpwBRtAMgxjnQwgXiqQkyf6p+ YGR0NYbSBrgybleLmoDI0VFqnj0g/bECdC9B5PAUISF7gKrlF6D1G6A74ChVatWalP2My8AAp8OB HaDuKkFgDw6sNhzagV0J7B8J16251ycX+KkeUIb/a6S/9A2ULQ824XBrCQAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMC0wOC0yMFQxNjoyNzowNSswMDowMARjWAQAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjAtMDgtMjBUMTY6Mjc6MDUrMDA6MDB1PuC4AAAAAElFTkSuQmCC X-Now-Playing: The Declining Winter's _Endless Scenery_: "No Stalgia" In-Reply-To: <87wo1tuwxo.fsf@web.de> (Michael Heerdegen's message of "Thu, 20 Aug 2020 18:03:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185719 Archived-At: Michael Heerdegen writes: > Lars Ingebrigtsen writes: > >> I've tried sprinkling some messaging liberally over cconv-analyze-form, >> and I'm unable to make it trigger in the test case. It does seem likely >> that the error is from a dolist somewhere, but it seems to happen before >> we get to that function... > > Did you enable lexical-binding mode? I guess it will make a difference. > A had done it AFAIR. Ah, yes, that made a difference. With the following patch I get: larsi@xo:~/src/emacs/trunk$ emake ; ./src/emacs -Q --batch -f batch-byte-compile /tmp/r.el ELC emacs-lisp/cconv.elc In toplevel form: /tmp/r.el:3:1: Error: Wrong type argument: proper-list-p, (a . b) Does this makes sense to everybody? diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el index 351a097ad1..c024cda876 100644 --- a/lisp/emacs-lisp/cconv.el +++ b/lisp/emacs-lisp/cconv.el @@ -750,6 +750,8 @@ cconv-analyze-form ;; (`(declare . ,_) nil) ;The args don't contain code. (`(,_ . ,body-forms) ; First element is a function or whatever. + (unless (listp body-forms) + (signal 'wrong-type-argument (list 'proper-list-p form))) (dolist (form body-forms) (cconv-analyze-form form env))) ((pred symbolp) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no