* bug#43382: [PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map
@ 2020-09-13 20:44 akater
2020-09-13 23:08 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: akater @ 2020-09-13 20:44 UTC (permalink / raw)
To: 43382
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
Looks like a mistake in docstring:
* lisp/progmodes/compile.el (compilation-mode-map)
Remove mention of compilation-minor-mode-map as comment in the body says
;; Don't inherit from compilation-minor-mode-map,
;; because that introduces a menu bar item we don't want.
;; That confuses C-down-mouse-3.
and the map actually inherits from special-mode-map
---
lisp/progmodes/compile.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 13b672bd53..7ac5405ab1 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2090,8 +2090,7 @@ define-key map [menu-bar compilation compilation-compile]
'(menu-item "Compile..." compile
:help "Compile the program including the current buffer. Default: run `make'"))
map)
- "Keymap for compilation log buffers.
-`compilation-minor-mode-map' is a parent of this.")
+ "Keymap for compilation log buffers.")
(defvar compilation-mode-tool-bar-map
;; When bootstrapping, tool-bar-map is not properly initialized yet,
--
2.26.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#43382: [PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map
2020-09-13 20:44 bug#43382: [PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map akater
@ 2020-09-13 23:08 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-09-13 23:08 UTC (permalink / raw)
To: akater; +Cc: 43382
akater <nuclearspace@gmail.com> writes:
> Looks like a mistake in docstring:
>
> * lisp/progmodes/compile.el (compilation-mode-map)
>
> Remove mention of compilation-minor-mode-map as comment in the body says
>
> ;; Don't inherit from compilation-minor-mode-map,
> ;; because that introduces a menu bar item we don't want.
> ;; That confuses C-down-mouse-3.
>
> and the map actually inherits from special-mode-map
Thanks; patch applied to Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-13 23:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-13 20:44 bug#43382: [PATCH] Remove mention of compilation-minor-mode-map from docstring of compilation-mode-map akater
2020-09-13 23:08 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).