From: Hugh Daschbach <hugh@ccss.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 43252@debbugs.gnu.org
Subject: bug#43252: 27.1; DBus properties lack type hints or overrides
Date: Thu, 17 Sep 2020 11:42:09 -0700 [thread overview]
Message-ID: <87bli49rem.fsf@ccss.com> (raw)
In-Reply-To: <87a6xor25b.fsf@gmx.de>
Michael Albinus writes:
> Hugh Daschbach <hugh@ccss.com> writes:
>
> Hi Hugh,
>
>>> this succeeds, we could implement a counterpart to the
>>> dbus-monitor
>>> program in Elisp. And you would be able to access this
>>> information
>>
>> Excellent. I can now parse the output of dbus-monitor. But
>> capturing
>
> Implementation is more complex than expected. Due to its nature,
> org.freedesktop.DBus.Monitoring.BecomeMonitor requires another
> (parallel) connection to the bus. This is not foreseen yet in
> dbusbind.c;
> will see how it could fly.
>
> What I could provide just now is an implementation which runs in
> *another* Emacs instance. This could be used for monitoring
> only,
> because it is another connection to the bus per definition. Are
> you
> interested to get such a partial implementation?
I'm interested in whatever you want to implement. I see signature
verification useful for testing rather than an exposed feature.
From what I can see from looking at dbus-monitor output the
correct
property types are being exposed now. It seems to be working.
So whatever we approach we take, the benefit is early warning of
future
regressions. You are a better judge of benefit of additional
effort
than I.
A second Emacs instance seems to offer the same asynchronous
output
gathering issues that dbus-monitor poses. It does eliminates the
ad-hoc
parser.
If you have a longer term goal, I'd suggest pursuing that rather
than
something partial that you'll want to replace later.
But I have no objection to a parallel instance to gather request
signatures.
>> Do you have
>> an issue with rolling that up in a macro?
>
> No objection. But comments :-)
>
>> (defmacro dbus-test05-test-property (name value expected)
>> `(let ((byte-array ,name))
>
> I wouldn't call the variable "byte-array"; it could be anything
> during
> test. Call it "property" or alike.
Fixed
>> (should
>> (equal
>> (dbus-register-property
>> :session dbus--test-service dbus--test-path
>> dbus--test-interface ,name :read
>
> I would use access type :readwrite. We want also to test
> dbus-set-property.
Yes, I've added a set property test. I'll move access to a
parameter so
I can do both positive and negative testing; confirm that :read
prevents
writes.
Which raises the question, should dbus-set-property function call
fail
for a local property that isn't :readwrite, or should that only be
prevented by incoming messages? Do we require that
dbus-register-property be used to update a :read access property.
>> ,value)
>> `((:property :session ,,dbus--test-interface ,,name)
>> (,dbus--test-service ,,dbus--test-path))))
>
> What are the double commas good for? Typos?
I had nested quasi-quoted expressions. I'm working to avoid that.
So
that was a bug.
>> (should
>> (equal
>> (dbus-get-property
>> :session dbus--test-service dbus--test-path
>> dbus--test-interface ,name)
>> ,expected))
>>
>> ;; a test for `dbus-get-property' shall be added.
>
> That's my typo - dbus-set-property is meant. And yes, it shall
> also be
> here. So you might need macro arguments value1 expected1 value2
> expected2.
I assumed as much. I just carried the comment around blindly.
I've
changed what I sent you to accept a list of pairs of values and
expected
return sexps. I use the first pair on the list for
dbus-register-property, verify retrieval, then use
dbus-set-property to
update and verify the property from the remaining pairs.
I need more testing and a cleanup pass. I'll pass along a better
version when
I think it's ready for review.
I've started a few "should fail" tests.
Cheers,
Hugh
next prev parent reply other threads:[~2020-09-17 18:42 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 0:54 bug#43252: 27.1; DBus properties lack type hints or overrides Hugh Daschbach
2020-09-07 7:48 ` Michael Albinus
2020-09-07 17:35 ` Hugh Daschbach
2020-09-07 18:00 ` Michael Albinus
2020-09-07 19:18 ` Hugh Daschbach
2020-09-08 14:36 ` Michael Albinus
2020-09-09 4:10 ` Hugh Daschbach
2020-09-09 4:25 ` Hugh Daschbach
2020-09-09 13:25 ` Michael Albinus
2020-09-09 16:12 ` Hugh Daschbach
2020-09-09 17:43 ` Michael Albinus
[not found] ` <874ko6979w.fsf@gmx.de>
[not found] ` <87v9gm9x9i.fsf@ccss.com>
2020-09-10 14:59 ` Michael Albinus
2020-09-10 16:57 ` Michael Albinus
2020-09-10 19:09 ` Hugh Daschbach
2020-09-11 8:46 ` Michael Albinus
2020-09-10 22:53 ` Hugh Daschbach
2020-09-11 9:57 ` Michael Albinus
2020-09-11 14:19 ` Michael Albinus
2020-09-15 4:05 ` Hugh Daschbach
2020-09-16 12:47 ` Michael Albinus
2020-09-16 22:23 ` Hugh Daschbach
2020-09-17 12:58 ` Michael Albinus
2020-09-17 18:42 ` Hugh Daschbach [this message]
2020-09-18 6:28 ` Hugh Daschbach
2020-09-18 9:55 ` Michael Albinus
2020-09-18 13:42 ` Michael Albinus
2020-09-18 15:50 ` Michael Albinus
2020-09-18 9:36 ` Michael Albinus
2020-09-19 3:32 ` Hugh Daschbach
2020-09-20 15:05 ` Michael Albinus
2020-09-21 11:50 ` Michael Albinus
2020-09-22 3:48 ` Hugh Daschbach
2020-09-22 16:09 ` Michael Albinus
2020-09-22 17:36 ` Michael Albinus
2020-09-23 3:30 ` Hugh Daschbach
2020-09-23 3:34 ` Hugh Daschbach
2020-09-23 7:44 ` Michael Albinus
2020-09-23 17:32 ` Michael Albinus
2020-09-24 3:02 ` Hugh Daschbach
2020-09-24 8:48 ` Michael Albinus
2020-09-25 4:16 ` Hugh Daschbach
2020-09-26 1:27 ` Hugh Daschbach
2020-09-26 9:51 ` Michael Albinus
2020-09-28 3:00 ` Hugh Daschbach
2020-09-28 12:55 ` Michael Albinus
2020-09-28 23:17 ` Hugh Daschbach
2020-09-29 12:22 ` Michael Albinus
2020-09-29 21:51 ` Hugh Daschbach
2020-09-30 9:34 ` Michael Albinus
2020-09-30 10:42 ` Michael Albinus
2020-09-30 16:39 ` Hugh Daschbach
2020-09-10 8:00 ` bug#43252: Fwd: " Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bli49rem.fsf@ccss.com \
--to=hugh@ccss.com \
--cc=43252@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).