From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#43252: 27.1; DBus properties lack type hints or overrides Date: Fri, 18 Sep 2020 11:55:45 +0200 Message-ID: <87bli39zoe.fsf@gmx.de> References: <87v9gqquct.fsf@ccss.com> <87imcqdo38.fsf@gmx.de> <87sgbtqylc.fsf@ccss.com> <87sgbtcvqs.fsf@gmx.de> <87pn6xqtsz.fsf@ccss.com> <87363sl4hs.fsf@gmx.de> <877dt3bnfl.fsf@ccss.com> <878sdj84kn.fsf@gmx.de> <871rjbaq05.fsf@ccss.com> <874ko6979w.fsf@gmx.de> <87v9gm9x9i.fsf@ccss.com> <871rj9k78r.fsf@gmx.de> <87imclwow5.fsf@gmx.de> <87pn6t9rbq.fsf@ccss.com> <87y2lggzvd.fsf@gmx.de> <87h7rzadlo.fsf@ccss.com> <87k0wtrir2.fsf@gmx.de> <87een19x9n.fsf@ccss.com> <87a6xor25b.fsf@gmx.de> <87bli49rem.fsf@ccss.com> <878sd7a99p.fsf@ccss.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5347"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43252@debbugs.gnu.org To: Hugh Daschbach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 11:58:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJD9f-0001Ie-S3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 11:58:11 +0200 Original-Received: from localhost ([::1]:38018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJD9e-0003Yu-Nz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 05:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJD7c-00020G-LP for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 05:56:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJD7a-0000JK-IU for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 05:56:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJD7a-0003aN-FZ for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 05:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 09:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43252 X-GNU-PR-Package: emacs Original-Received: via spool by 43252-submit@debbugs.gnu.org id=B43252.160042295613770 (code B ref 43252); Fri, 18 Sep 2020 09:56:02 +0000 Original-Received: (at 43252) by debbugs.gnu.org; 18 Sep 2020 09:55:56 +0000 Original-Received: from localhost ([127.0.0.1]:40942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJD7U-0003a1-8A for submit@debbugs.gnu.org; Fri, 18 Sep 2020 05:55:56 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:49755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJD7S-0003Zm-Af for 43252@debbugs.gnu.org; Fri, 18 Sep 2020 05:55:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600422946; bh=/QDmRDJ/VaktAC/ra/oIuGj0h+DOyoC709tEsInpDaA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=l4CepywAhsJlS7LSAsGoZ2fxyJuf5ulfpy84XNP1jF4qlat0g952NJsFbDsmdwFnq PZ+LJe1jdMszMXjhQQ647wK7ayLDcVuHZhlIZV4gDGGN2wwiPsTvGKSEgNBhzcDtX0 DS1yMpoRA3tuz6+la+gsHllpyjgCxYKQPrAL27gM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([178.20.93.248]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MpUUm-1kp1lG0xO0-00ptZI; Fri, 18 Sep 2020 11:55:46 +0200 In-Reply-To: <878sd7a99p.fsf@ccss.com> (Hugh Daschbach's message of "Thu, 17 Sep 2020 23:28:34 -0700") X-Provags-ID: V03:K1:HT4rtP1PU0LWqW40okU8qKG9n3U/0lrHMy6R6ev34IeC9mVUCPb cPSQgzTKFCFp7wFiJclHxLGueJDbpoM775XbtMHoIyUaBsOL2Nawe9EiyOhfR3S8A8e5Y7T NPSMh3qDjsP0eedhPLSdvN33kO691BBTo/OF35nhp/TXJmqUgxZC/hWprGFo4nN7fne35Rs GhVNa+9WC5Jt80L+qxlvw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Dp5PaCc/iuY=:AjdqXGinVyHiz9njkBF/ye lfYqNQAJM4tP4QGlhlca+f4GhwVwaItzxNW7+UVr2DZBuR/uo8PnTxEXydwMWBwzFvUg6eg7M L/NfV2TmEF9Kf/z/nYTz+vU2ojKYbzzQDDyApevBCU6gQ+fGAey0mcL7QUEKmDk//sF6g+Dud C0gApMn1foC5+0I7TwsabX21Lw2QmfmMR3gUtgreGlqUPnN+gl22NVNAS8OwbC5H0bzFWXEgJ tUkUj/7BPRkhWiF3NKd4Nd2ICuX2Gz08QKSIyV1nkFoji4xCKjGnp2FcfxSDvUS2oSgAFYmWG FfGJs3EFh2PC+OaMuZOtL1WfpSZ3uiQ3QLp7tfTijQEkGefwIIyCmSBP10CzI8zCHpBDmuQGA zvPjUR45Bk5W2+d4UzGgrd/KrTw8dBULoWoU/DSSHEnLNzYV3duRkBXrAVgHZOTnbLxRHe1/J Y2svWeDP/J+LJwhjSe4nZ8uvIqU9vZvAxh0DHrV3FUa2QRlfFWJFRVJHHootX+vfxLZaT0jA3 f9f6dRiX2YPPQNCQMjVp8G/vxSzRZ0f0AKMoEly+IVGVsi3h+R2Y4Eu61XwpXIWPP+8rzAZpH b6ojncQY5Z/m6kVuJotASGSoReDq065wyWUN6FnQORzMVSeYO8KdTIbqrBilSTm0wTaaXTprW wcPpSc1k9otX+HW6nl/yay5yqeIQdZLBdKJ5UL022WCkQ+ZSmoOsAy8TaYRMCSOuIQJ1v15FC dXBSqAKEPmM06hEAV6oJEAGLXM8x9fwu6WZVklcoCUNPTPGBDlLVFKoiIAJ+33J7QHJruv5O X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188283 Archived-At: Hugh Daschbach writes: Hi Hugh, >> I need more testing and a cleanup pass. I'll pass along a better >> version when >> I think it's ready for review. >> >> I've started a few "should fail" tests. > > I've made a bit of progress. I have a few tests that fail. There > doesn't seem to be any type checking on property set. But have a look > and see if you concur that these are real errors. I've attached a > patch. Well, before getting type information in dbus-event, it wasn't possible for dbus-property-handler to know the types of values provided by org.freedesktop.DBus.Properties.Set method calls. Therefore I've said, that the type used in dbus-register-property shall be inherited. This decision wasn't dictated by the D-Bus API, it was just an implementation restriction. Now, that the type information is preserved, I have abandoned this restriction. You can register a property with any type, and you can overwrite this property via an ofDP.Set call with a value of any other type. This is not forbidden by the D-Bus API (but highly discouraged, I guess). > In addition, I see a failure in dbus-test04-register-method: > >> (equal >> (dbus-error "org.freedesktop.DBus.Error.ServiceUnknown" "The name org.gnu.Emacs.TestDBus was not provided by any .service files") >> (dbus-error "org.freedesktop.DBus.Error.ServiceUnknown" "The name is not activatable")) Oops, yes. The intention of this check is to see, whether org.freedesktop.DBus.Error.ServiceUnknown is reported (it is). The additional explanation doesn't matter, and it seems to be different depending on the D-Bus daemon implementation (I'm using Fedora 32). So I've pushed a fix, which checks just for the D-Bus error name, w/o the additional text. > I'm starting to run out of ideas for additional tests. Suggestions > welcome. The major black hole seems to be dbus-introspect* tests. If you are interested? I fear writing them will be boring, so I haven't done them yet ... OTOH, they are not the most important part of Emacs' D-Bus implementation. > Cheers, > Hugh Best regards, Michael.