From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#43308: 28.0.50; Improvements to Edit->Search menu Date: Tue, 22 Sep 2020 21:10:13 +0300 Organization: LINKOV.NET Message-ID: <87blhxdatu.fsf@mail.linkov.net> References: <87zh5xiuk4.fsf@localhost>> <831rj9k79b.fsf@gnu.org>> > <83sgbpiqa7.fsf@gnu.org>> <87mu1xa380.fsf@mail.linkov.net>> <83imclii71.fsf@gnu.org>> <87wo1178cn.fsf@mail.linkov.net>> <83d02tifi3.fsf@gnu.org>> <87ft7cx6kh.fsf@localhost>> <83bli027is.fsf@gnu.org>> <498f6be5-f1ab-4f82-9cf1-ed5893f10ea1@default> <87wo0nbln5.fsf@mail.linkov.net> <6e21964e-a580-45ef-943f-a8ea97e58eef@default> <87sgbadxr9.fsf@mail.linkov.net> <83tuvpx5b4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18641"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 43308@debbugs.gnu.org, yantar92@gmail.com, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 22 20:20:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKmth-0004jP-6d for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 20:20:13 +0200 Original-Received: from localhost ([::1]:41348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKmtg-0005cM-18 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Sep 2020 14:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKmtW-0005bh-Nl for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 14:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kKmtW-0008W2-DL for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 14:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kKmtW-0001ob-9H for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2020 14:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2020 18:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43308 X-GNU-PR-Package: emacs Original-Received: via spool by 43308-submit@debbugs.gnu.org id=B43308.16007987626907 (code B ref 43308); Tue, 22 Sep 2020 18:20:02 +0000 Original-Received: (at 43308) by debbugs.gnu.org; 22 Sep 2020 18:19:22 +0000 Original-Received: from localhost ([127.0.0.1]:33316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKmss-0001nL-GL for submit@debbugs.gnu.org; Tue, 22 Sep 2020 14:19:22 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:57569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kKmsm-0001mi-5T for 43308@debbugs.gnu.org; Tue, 22 Sep 2020 14:19:18 -0400 Original-Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7A40D100006; Tue, 22 Sep 2020 18:19:08 +0000 (UTC) In-Reply-To: <83tuvpx5b4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Sep 2020 17:19:11 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188734 Archived-At: >> >> Why no keybindings are shown for nonincremental menu items? >> >> They still have keybindings, e.g. nonincremental forward search >> >> can be started with 'C-s RET', nonincremental backward search >> >> with 'C-r RET', nonincremental regexp search 'C-M-s RET', etc. >> > >> > I suppose I could add some explicitly, with :keys. >> > That makes sense. Unfortunately, none show up >> > automatically. It would be good to somehow fix that. >> >> How about the following patch? > > But the keys this will show don't invoke the same commands, they > invoke slightly different commands, don't they? I don't think we ever > show keys that invoke a different command, why do this here? The comment in 'nonincremental-search-forward' says: ;; Ideally, this whole command would be equivalent to `C-s RET'. This seems to imply that currently it's not equivalent. Then indeed displaying wrong keys would be misleading. >> Another problem is that selecting "Continue Tags Search" >> signals the error: >> >> emacs -Q >> Select "Edit" -> "Search" -> "Continue Tags Search" >> >> Lisp error: (wrong-type-argument commandp fileloop-continue) > > I guess this is a leftover from migration to Xref. Do you mean these obsolete menu items should be removed since now there are Xref commands in the "Go To" submenu?