From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#44294: No widen by xref-find-definitions Date: Thu, 29 Oct 2020 23:20:37 +0200 Organization: LINKOV.NET Message-ID: <87blgkiva2.fsf@mail.linkov.net> References: <87mu06p1aw.fsf_-_@mail.linkov.net> <9a425c29-56c5-90f4-ffbc-19bbd0643d03@yandex.ru> <87tuuds8iy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30258"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) To: 44294@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 29 22:25:56 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYFQi-0007nh-Cr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 22:25:56 +0100 Original-Received: from localhost ([::1]:57770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYFQh-0008QG-FR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 17:25:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYFPu-00086P-DD for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:25:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYFPq-0001hk-3A for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYFPp-0001ra-VV for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Oct 2020 21:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 44294-submit@debbugs.gnu.org id=B44294.16040066527067 (code B ref 44294); Thu, 29 Oct 2020 21:25:01 +0000 Original-Received: (at 44294) by debbugs.gnu.org; 29 Oct 2020 21:24:12 +0000 Original-Received: from localhost ([127.0.0.1]:55113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFP1-0001pu-T1 for submit@debbugs.gnu.org; Thu, 29 Oct 2020 17:24:12 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:40287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFOy-0001pE-2l for 44294@debbugs.gnu.org; Thu, 29 Oct 2020 17:24:08 -0400 X-Originating-IP: 91.129.102.160 Original-Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 67A1640008 for <44294@debbugs.gnu.org>; Thu, 29 Oct 2020 21:24:00 +0000 (UTC) In-Reply-To: <87tuuds8iy.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 29 Oct 2020 11:09:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192002 Archived-At: BTW, I noticed that when isearch fails it doesn't inform the user that there are possibly more matches outside the narrowed region: diff --git a/lisp/isearch.el b/lisp/isearch.el index c3d5ff2d31..dae7618556 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -3276,6 +3276,8 @@ isearch-message-prefix (multi-isearch-file-list "multi-file ") (multi-isearch-buffer-list "multi-buffer ") (t "")) + (if (and (not isearch-success) (buffer-narrowed-p) widen-automatically) + "narrowed-buffer " "") (or isearch-message-prefix-add "") (if nonincremental "search" "I-search") (if isearch-forward "" " backward")