From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#33341: 27.0.50; Undo log merging and change groups Date: Thu, 26 Nov 2020 13:34:40 +0100 Message-ID: <87blfkthy7.fsf@gnus.org> References: <877ehk3ve4.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39661"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , 33341@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 13:37:47 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiGWw-000AEH-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 13:37:46 +0100 Original-Received: from localhost ([::1]:58870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiGWv-0004ZW-Se for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 07:37:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiGUI-0003dZ-4Z for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 07:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiGUH-0002jG-Rh for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 07:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiGUH-0001FT-NM for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 07:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 12:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33341 X-GNU-PR-Package: emacs Original-Received: via spool by 33341-submit@debbugs.gnu.org id=B33341.16063940934780 (code B ref 33341); Thu, 26 Nov 2020 12:35:01 +0000 Original-Received: (at 33341) by debbugs.gnu.org; 26 Nov 2020 12:34:53 +0000 Original-Received: from localhost ([127.0.0.1]:39988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiGU9-0001F1-Ik for submit@debbugs.gnu.org; Thu, 26 Nov 2020 07:34:53 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:49770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiGU8-0001Em-1S for 33341@debbugs.gnu.org; Thu, 26 Nov 2020 07:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xkSCSaDWbYaR9RlCEslYob0X7sLpXvosm0ArlbWoY3c=; b=htsXKiELBy9nUK1hYDWc3okahn 4fMRVLKYFPd6gblyZ4Gts+wnhRyq0MwMNhHGCmI6A1tEB3CuRFr+fI+UOqPMDRSU41CUFfaAr5nGj Xw5MCR0mZu++3/AXb8h9T3nT5BH5miK57KRCH619j5ib+7BpINWqTLbJwKooufQL4ar8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiGTx-0001Fd-SX; Thu, 26 Nov 2020 13:34:44 +0100 X-Now-Playing: Simple Minds's _Sons and Fascination_: "This Earth That You Walk Upon" In-Reply-To: <877ehk3ve4.fsf@web.de> (Michael Heerdegen's message of "Sun, 11 Nov 2018 08:50:43 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194296 Archived-At: Michael Heerdegen writes: > I have been playing with the undo change group functions. I found > `cancel-change-group' does not always work as expected. For example, if > you define > > (defun my-test-change-groups () > (interactive) > (insert "0\n") > (let ((g (prepare-change-group))) > (activate-change-group g) > (insert "b\n") > (insert "c\n") > (cancel-change-group g))) > > and call that command in some random buffer, the final > `cancel-change-group' has no effect (i.e. nothing is reverted). In > other, similar examples, `cancel-change-group' seems to revert more than > it should. Hm... Well, after running this command, hitting "undo" removes all the three lines, which is what I'd expect? Since you cancelled the change group? Or... Hm. Well, calling accept-change-group has exactly the same effect, so it seems like I'm misunderstanding how this is supposed to work. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no