unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: mail@ap4y.me
Cc: 21896@debbugs.gnu.org
Subject: bug#21896: 24.5; Inconsistent handling of braces in smie
Date: Thu, 03 Dec 2020 11:44:26 +0100	[thread overview]
Message-ID: <87blfbuq2d.fsf@gnus.org> (raw)
In-Reply-To: <87bnayzjbg.fsf@home.i-did-not-set--mail-host-address--so-tickle-me> (mail@ap4y.me's message of "Fri, 13 Nov 2015 16:09:39 +1300")

mail@ap4y.me writes:

> Using 2 possible ways of hanling braces tokens:
>
> 1. Using default lexer rules for braces (as per documentation).
> 2. Manually tokenizing braces in lexer (uncomment lines 196-197 and
> 213-214 in provided source file)
>
> I'm getting different indentation results. For the case number 1,
> indentation of the consutriction:
>
> if true {
>     |foo
> }
>
> is invalid and from the logs it seems like smie doesn't parse this
> constructor correctly.
>
> For the case number 2 indentation works as expected, but for the
> construction like this (which is a simple sexp):
>
> {
> }|
>
> I'm getting "Mismatching parenthesis" error when I'm calling
> blink-matching-open.

(This bug report unfortunately got no response at the time.)

I tried reproducing this bug in Emacs 28 by loading the supplied Swift
mode, and then indenting the the example, and I got this:

if true {
           foo
       }

Which I assume isn't correct?

For the second problem, blink-matching-open seemed to do the correct
thing.

Before debugging further -- are you still seeing these problems with a
more recent Emacs/swift mode?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-12-03 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  3:09 bug#21896: 24.5; Inconsistent handling of braces in smie mail
2020-12-03 10:44 ` Lars Ingebrigtsen [this message]
2021-01-19  7:35   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blfbuq2d.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=21896@debbugs.gnu.org \
    --cc=mail@ap4y.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).