From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45747: 27.1; mercury-mode font lock bug Date: Sun, 10 Jan 2021 13:51:11 +0100 Message-ID: <87bldxuf9c.fsf_-_@gnus.org> References: <20210109132243.zrd4ojp24ps4desd@sildranDT.localdomain> <20210109152949.6tpygnvvbyj4jtlx@sildranDT.localdomain> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30022"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45747@debbugs.gnu.org To: k3tu0isui@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 10 13:52:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyaCW-0007fU-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 13:52:08 +0100 Original-Received: from localhost ([::1]:45562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyaCV-0007p6-EC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 07:52:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyaCP-0007oz-W9 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 07:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyaCP-0002g2-PA for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 07:52:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyaCP-0003p3-Mz for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 07:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2021 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45747 X-GNU-PR-Package: emacs Original-Received: via spool by 45747-submit@debbugs.gnu.org id=B45747.161028308314616 (code B ref 45747); Sun, 10 Jan 2021 12:52:01 +0000 Original-Received: (at 45747) by debbugs.gnu.org; 10 Jan 2021 12:51:23 +0000 Original-Received: from localhost ([127.0.0.1]:53375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyaBm-0003ng-MI for submit@debbugs.gnu.org; Sun, 10 Jan 2021 07:51:22 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:40498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyaBk-0003nS-NE for 45747@debbugs.gnu.org; Sun, 10 Jan 2021 07:51:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Hg50QKPfxns0GEGLorh25mDdj1/TBojdrFq9XAG+p7s=; b=tpzpJsjjd+WPz6+htc5HbjpVmT 6A2CvBopXzyhVAsJK2rBj+nOGUsSOAI6G+YPnZqbpGUAqs0iJxTbTqwpYeYIooo1N5hukGsB6gXRn og9Zs3/b4qYh16gMsih3dU2JPeLgvm3iHdXwQnhVXbIBUujhp1X0UE1uPmz33tSWdEdQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyaBc-0006re-AO; Sun, 10 Jan 2021 13:51:14 +0100 X-Now-Playing: Momus's _Tender Pervert_: "Ice King" In-Reply-To: <20210109152949.6tpygnvvbyj4jtlx@sildranDT.localdomain> (k3tu0isui@gmail.com's message of "Sat, 9 Jan 2021 20:59:49 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197599 Archived-At: k3tu0isui@gmail.com writes: > The problem seems to be arising due to mercury-mode being defined as a > major-mode rather than a different system under prolog mode. I changed > a line in prolog-font-lock-keywords to work with mercury-mode and > added a call to prolog-mode-variables in define-derived-mode > mercury-mode to setup the required variables for font lock keywords. [...] > (define-derived-mode mercury-mode prolog-mode "Prolog[Mercury]" > "Major mode for editing Mercury programs. > Actually this is just customized `prolog-mode'." > - (setq-local prolog-system 'mercury)) > + (setq-local prolog-system 'mercury) > + (prolog-mode-variables)) I'm not a Mercury mode user, but I don't quite understand this bit of the patch -- mercury-mode is derived from prolog-mode, so `prolog-mode-variables' should already be run at this point? So is that bit necessary/ > - ((eq major-mode 'prolog-mode) > + ((or (eq major-mode 'prolog-mode) > + (eq major-mode 'mercury-mode)) > (list > head-predicates > head-predicates-1 This could perhaps be: diff --git a/lisp/progmodes/prolog.el b/lisp/progmodes/prolog.el index c8f6c12a3f..1ac0210f81 100644 --- a/lisp/progmodes/prolog.el +++ b/lisp/progmodes/prolog.el @@ -2082,7 +2082,7 @@ prolog-font-lock-keywords (delq nil (cond - ((eq major-mode 'prolog-mode) + ((derived-mode-p 'prolog-mode) (list head-predicates head-predicates-1 -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no