From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45831: 28.0.50; list-colors-display callback arg needs to evaluate to a function? Date: Fri, 15 Jan 2021 22:04:39 +0000 Message-ID: <87bldphn60.fsf@tcd.ie> References: <5ffe3063.1c69fb81.52f23.11a7@mx.google.com> <5ffe37e4.1c69fb81.411a.0f1c@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1764"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45831@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 23:05:46 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0XE1-0000Ke-K6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 23:05:45 +0100 Original-Received: from localhost ([::1]:59812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0XE0-00073e-Js for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 17:05:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0XDO-000737-Kq for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 17:05:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0XDK-0007Vh-2B for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 17:05:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0XDJ-0001dE-Ro for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 17:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 22:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45831-submit@debbugs.gnu.org id=B45831.16107482926253 (code B ref 45831); Fri, 15 Jan 2021 22:05:01 +0000 Original-Received: (at 45831) by debbugs.gnu.org; 15 Jan 2021 22:04:52 +0000 Original-Received: from localhost ([127.0.0.1]:41893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0XD9-0001cn-So for submit@debbugs.gnu.org; Fri, 15 Jan 2021 17:04:52 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:37962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0XD6-0001cV-Dt for 45831@debbugs.gnu.org; Fri, 15 Jan 2021 17:04:51 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id a9so7274381wrt.5 for <45831@debbugs.gnu.org>; Fri, 15 Jan 2021 14:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5Wadyts6deI9gJtUlVjTwrMCtjXTJSqYTu1ruzr9kdY=; b=wCmaH8Em6WvuLtbxmxroidbK1EipFbqt/cLDz7UUdP8/RHnOtzne1mNQUJHcjkA9Ic zkaQrwj3onrqfvmnaNM/ehYCzoYZAAd50AfH0/yDd1+4YhhnmsSSPjW/d5IseqzJcz7r G5XiVedt79o9paxZw46UxtY8Xuxw3v33kNuwRIHGDX1AbZyhP8XBbyjUjwXl8MWhniJx 8zMbjudfXOONjoybsLH0HCxwTTRmMo7+gOR+iWd+8y38gm8YpRgQKTQia5u+W4zhkVV5 3c/kqMXsr/G2VWKlznRftVtjGTwsvEW1qMADHlE3fzu27JEryM3x7Vvv38Our7dyDXpa HYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5Wadyts6deI9gJtUlVjTwrMCtjXTJSqYTu1ruzr9kdY=; b=PSsFo5o2MbdVq7753N8mcrQ7isCeTG7rE97nkeKQ/rvXiQSLSio+pUVQuu5GJScFeU J1VF6wfAJR5ScHH4RXeNJuTR5vGIzY2RpAEHVTmBQxcqoZ90eQhCT5Z8HRSTxcNZJrXp EGlFG37xGvlsxiJcqhbhWMOR07FJx2oc7H7jnn5SBXhTV5+ffPt345TQ4KLHkf4GAonA 3OLCO4lwtd8/OOXD1J5avARl32immrQ9elreHkqiF3i/Tf3/Zcm5pTtzOZPJQgmLhtn3 5K4KUPBbwE/iP3QNorr5ITFxQxNBXGJbvqmUR1tV/jmuOCJfqYlpcZCNrMkTUEL84hEF Q7Uw== X-Gm-Message-State: AOAM533KVSGwwIfiotvU1THwq/ivAOlnDzBngATnLi8Kk+ZItmAK0GvU edgsSx7Cc45Zn0IJ+OaAE7yXiQ== X-Google-Smtp-Source: ABdhPJyM9sZu/e/5/EtslXlWZPQ5UIXlf5Ezl0wKgiti0mNDvfqU7Ua3Mu8Zdq4YZkf9WEBGyBycgA== X-Received: by 2002:adf:f401:: with SMTP id g1mr15176037wro.258.1610748282574; Fri, 15 Jan 2021 14:04:42 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id y6sm15910488wrp.6.2021.01.15.14.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 14:04:41 -0800 (PST) In-Reply-To: <5ffe37e4.1c69fb81.411a.0f1c@mx.google.com> (Mauro Aranda's message of "Tue, 12 Jan 2021 20:59:29 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198003 Archived-At: Mauro Aranda writes: > (defun list-colors-print (list &optional callback) > (let ((callback-fn > - (if callback > - `(lambda (button) > - (funcall ,callback (button-get button 'color-name)))))) > + ;; Expect CALLBACK to be a function, but allow it to be a form that > + ;; evaluates to a function, for backward-compatibility. (Bug#45831) > + (cond ((functionp callback) > + (lambda (button) > + (funcall callback (button-get button 'color-name)))) > + (callback > + `(lambda (button) > + (funcall ,callback (button-get button 'color-name))))))) Why not a single evaluated closure, e.g. like the following? (let ((callback-fn (when callback ;; Expect CALLBACK to be a function, but allow it to be a form that ;; evaluates to a function, for backward-compatibility (bug#45831). (or (functionp callback) (setq callback (eval callback lexical-binding))) (lambda (button) (funcall callback (button-get button 'color-name)))))) ...) Thanks, -- Basil