unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46240@debbugs.gnu.org
Subject: bug#46240: Sorting order of read-char-by-name
Date: Wed, 03 Feb 2021 19:27:54 +0200	[thread overview]
Message-ID: <87bld1t6z9.fsf@mail.linkov.net> (raw)
In-Reply-To: <838s865mxs.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Feb 2021 20:44:47 +0200")

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

> So maybe we need this to be an opt-in behavior.

Here is an option for this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: read-char-by-name-sort-function.patch --]
[-- Type: text/x-diff, Size: 2430 bytes --]

diff --git a/etc/NEWS b/etc/NEWS
index 7cdb9d9430..0ff78e58e1 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -850,6 +850,11 @@ iso-transl RET', it supports the same key sequences as 'C-x 8',
 so e.g. like 'C-x 8 [' inserts a left single quotation mark,
 'C-x \ [' does the same.
 
+---
+*** New user option 'read-char-by-name-sort-function'.
+It can enable sorting the characters of completion from
+'C-x 8 RET TAB' by codepoints instead of character names.
+
 ---
 *** Improved language transliteration in Malayalam input methods.
 Added a new Mozhi scheme.  The inapplicable ITRANS scheme is now
diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el
index 5dc3de4422..6e1e045a4a 100644
--- a/lisp/international/mule-cmds.el
+++ b/lisp/international/mule-cmds.el
@@ -3083,6 +3083,12 @@ mule--ucs-names-affixation
               (list name (concat (if char (format "%c" char) " ") "\t") "")))
           names))
 
+(defun mule--ucs-names-sort-by-code (names)
+  (let* ((codes-and-names
+          (mapcar (lambda (name) (cons (gethash name ucs-names) name)) names))
+         (sorted (sort codes-and-names (lambda (a b) (< (car a) (car b))))))
+    (mapcar #'cdr sorted)))
+
 (defun char-from-name (string &optional ignore-case)
   "Return a character as a number from its Unicode name STRING.
 If optional IGNORE-CASE is non-nil, ignore case in STRING.
@@ -3104,6 +3110,16 @@ char-from-name
                                            ignore-case))
                 code)))))))
 
+(defcustom read-char-by-name-sort-function nil
+  "Function to sort characters displayed by `read-char-by-name' completion."
+  :type '(choice
+          (const :tag "Sort by character names" nil)
+          (const :tag "Sort by character codepoints"
+                 mule--ucs-names-sort-by-code)
+          (function :tag "Custom function"))
+  :group 'mule
+  :version "28.1")
+
 (defun read-char-by-name (prompt)
   "Read a character by its Unicode name or hex number string.
 Display PROMPT and read a string that represents a character by its
@@ -3130,8 +3146,9 @@ read-char-by-name
 	   prompt
 	   (lambda (string pred action)
 	     (if (eq action 'metadata)
-		 '(metadata
+		 `(metadata
 		   (affixation-function . mule--ucs-names-affixation)
+		   (display-sort-function . ,read-char-by-name-sort-function)
 		   (category . unicode-name))
 	       (complete-with-action action (ucs-names) string pred)))))
 	 (char

  reply	other threads:[~2021-02-03 17:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 17:23 bug#46240: Sorting order of read-char-by-name Juri Linkov
2021-02-01 17:41 ` Eli Zaretskii
2021-02-02  8:40   ` Lars Ingebrigtsen
2021-02-02 17:16     ` Juri Linkov
2021-02-02 17:57       ` bug#46240: [External] : " Drew Adams
2021-02-02 18:47       ` Eli Zaretskii
2021-02-03 15:38       ` Lars Ingebrigtsen
2021-02-03 18:02         ` Lars Ingebrigtsen
2021-02-03 18:17           ` Eli Zaretskii
2021-02-03 18:21             ` Lars Ingebrigtsen
2021-02-03 18:40               ` Eli Zaretskii
2021-02-03 19:43           ` Juri Linkov
2021-02-04  7:56             ` Lars Ingebrigtsen
2021-02-04  9:32               ` Juri Linkov
2021-02-04 16:19                 ` Lars Ingebrigtsen
2021-02-04 22:34                   ` Juri Linkov
2021-02-05  7:36                     ` Eli Zaretskii
2021-02-06 19:35                       ` Juri Linkov
2021-02-06 20:01                         ` Eli Zaretskii
2021-02-07 18:56                           ` Juri Linkov
2021-02-07 19:54                             ` Eli Zaretskii
2021-02-09 18:13                               ` Juri Linkov
2021-02-09 19:00                                 ` Eli Zaretskii
2021-02-09 19:16                                   ` Juri Linkov
2021-02-02 17:13   ` Juri Linkov
2021-02-02 18:44     ` Eli Zaretskii
2021-02-03 17:27       ` Juri Linkov [this message]
2021-02-03 17:54         ` Eli Zaretskii
2021-02-03 19:44           ` Juri Linkov
2021-02-03 15:35     ` Lars Ingebrigtsen
2021-02-01 19:35 ` bug#46240: [External] : " Drew Adams
2021-02-02 17:18   ` Juri Linkov
2021-02-02 17:49     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bld1t6z9.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=46240@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).